Merged
Conversation
vincenzopalazzo
approved these changes
Jun 11, 2024
Contributor
vincenzopalazzo
left a comment
There was a problem hiding this comment.
ACK 1583ada
I trust you with the LaTeX fixes, but I feel that we need something in the CI to check for this kind of typo. It seems really easy to make this kind of mistake.
Collaborator
t-bast
added a commit
to t-bast/bolts
that referenced
this pull request
Jul 11, 2024
This commit doesn't change the logic at all, it simply: - removes `realm` from onion test vector - cleans-up markdown formatting and indents - fixes typos and missing parenthesis - consistently uses `_` instead of `-` for field names - fixes math formatting (including changes from lightning#1169 and lightning#1158)
rustyrussell
pushed a commit
to rustyrussell/bolts
that referenced
this pull request
Jul 17, 2024
This commit doesn't change the logic at all, it simply: - removes `realm` from onion test vector - cleans-up markdown formatting and indents - fixes typos and missing parenthesis - consistently uses `_` instead of `-` for field names - fixes math formatting (including changes from lightning#1169 and lightning#1158)
Collaborator
|
The LateX fixes were included in #1181, so it looks like you can rebase to just keep the tiny changes to Bolt 3? |
All the test vectors use static keys now, which are listed above already as the local_payment_basepoint and remote_payment_basepoint. The keys listed here are the pre-static rotated ones: if you use these, the vectors don't work! We actually use the same basepoint for the HTLCs, but never spelled it out. So do that now, and these are the local/remote htlc keys. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
1583ada to
fb2f055
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.