Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: libproxy/libproxy
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: dff9a60
Choose a base ref
...
head repository: libproxy/libproxy
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 184c323
Choose a head ref
  • 15 commits
  • 8 files changed
  • 6 contributors

Commits on Mar 6, 2024

  1. Windows: Try all configured proxy resolution types (#278)

    On Windows, WPAD, PAC and manual proxy settings are not mutually
    exclusive. They can all be set and should be tried in that order.
    davids-work authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    90693ec View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Cleanup curl (#286)

    Release curl handle in dispose.
    
    Co-authored-by: Jan-Michael Brummer <jan-michael.brummer1@volkswagen.de>
    janbrummer and janbrummer authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    83e8bef View commit details
    Browse the repository at this point in the history
  2. Add release option (#287)

    In case release option is set to true, no git hooks are installed to the
    system.
    
    Fixes: #262
    
    Co-authored-by: Jan-Michael Brummer <jan-michael.brummer1@volkswagen.de>
    janbrummer and janbrummer authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    dc93aff View commit details
    Browse the repository at this point in the history
  3. Expose missing functions in symbol map (#288)

    px_proxy_factory_get_type and px_proxy_factory_copy should be in symbol
    map. Add it.
    
    Fixes: #281
    
    Co-authored-by: Jan-Michael Brummer <jan-michael.brummer1@volkswagen.de>
    janbrummer and janbrummer authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    3e1de38 View commit details
    Browse the repository at this point in the history
  4. Fix crash during unload (#289)

    Fixes: #285
    
    Co-authored-by: Jan-Michael Brummer <jan-michael.brummer1@volkswagen.de>
    janbrummer and janbrummer authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    55882f3 View commit details
    Browse the repository at this point in the history
  5. Log debug instead of warning on wpad pac failure (#290)

    Co-authored-by: Jan-Michael Brummer <jan-michael.brummer1@volkswagen.de>
    janbrummer and janbrummer authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    d49ebbb View commit details
    Browse the repository at this point in the history
  6. tests: Copy pxProxyFactory correctly

    The second argument to g_boxed_copy() is meant to be a pointer to the
    boxed instance itself, not a pointer to a pointer to the boxed instance.
    For example, `g_boxed_copy (G_TYPE_STRV, environ)` is correct (equivalent
    to g_strdupv() in this case), but `g_boxed_copy (G_TYPE_STRV, &environ)`
    would be incorrect. The same principle applies here.
    
    The test passed despite this because self->pf and
    &self->pf happen to both be pointer-sized, and as a result of
    #280, the data that is pointed
    to was copied byte-by-byte but not otherwise used; but this will no
    longer be true when #280 is fixed, so the test needs fixing first.
    
    Signed-off-by: Simon McVittie <smcv@debian.org>
    smcv authored and janbrummer committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    5cca651 View commit details
    Browse the repository at this point in the history
  7. px_proxy_factory_copy: Add a new reference to the manager

    Otherwise there is no guarantee that the object will continue to exist
    after the original factory is destroyed, and both the copy and the
    original factory will try to unref it when destroyed, which is a
    programming error.
    
    Resolves: #280
    Signed-off-by: Simon McVittie <smcv@debian.org>
    smcv authored and janbrummer committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    44a6d7e View commit details
    Browse the repository at this point in the history
  8. tests: Don't leak the copied pxProxyFactory

    Previously the copy was never freed, which hid the bugs fixed by the
    previous commits.
    
    Reproduces: #280
    Signed-off-by: Simon McVittie <smcv@debian.org>
    smcv authored and janbrummer committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    4e6202d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    df3ad90 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a51cfc3 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    dd5f9c8 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    6117c7a View commit details
    Browse the repository at this point in the history
  13. meson: Don't build OSX plugin on iOS

    Fails to build with:
    
    ../src/backend/plugins/config-osx/config-osx.c:284:29: error: 'SCDynamicStoreCopyProxies' is unavailable: not available on iOS
    
    Which is true, it's only available on macOS 10.1+
    
    https://developer.apple.com/documentation/systemconfiguration/1517088-scdynamicstorecopyproxies
    nirbheek authored and janbrummer committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    e776242 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Bump version to 0.5.5

    janbrummer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    184c323 View commit details
    Browse the repository at this point in the history
Loading