Merged
Conversation
px_proxy_factory_get_type and px_proxy_factory_copy should be in symbol map. Add it. Fixes: #281
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
=======================================
Coverage 72.70% 72.70%
=======================================
Files 16 16
Lines 850 850
Branches 242 242
=======================================
Hits 618 618
Misses 137 137
Partials 95 95 ☔ View full report in Codecov by Sentry. |
DimStar77
reviewed
Apr 2, 2024
| global: | ||
| px_proxy_factory_get_type; | ||
| px_proxy_factory_copy; | ||
| }; |
Contributor
There was a problem hiding this comment.
should be } LIBPROXY_0.4.16;
Contributor
There was a problem hiding this comment.
See for the format of the map: https://sourceware.org/binutils/docs/ld/VERSION.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
px_proxy_factory_get_type and px_proxy_factory_copy should be in symbol map. Add it.
Fixes: #281