Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dff9a60) 72.67% compared to head (a35525a) 72.67%.

@@           Coverage Diff           @@
##             main     #278   +/-   ##
=======================================
  Coverage   72.67%   72.67%           
=======================================
  Files          16       16           
  Lines         849      849           
  Branches      241      241           
=======================================
  Hits          617      617           
  Misses        137      137           
  Partials       95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

libproxy is using a specific configuration logic, and it should be the same among all systems: https://libproxy.github.io/libproxy/configuration-logic.html

The problem is that this makes libproxy a LOT less useful on Windows. "Automatically detect settings" (the switch that controls whether or not WPAD is used) seems to be turned on by default on many installations, and when/if manual settings are configured, it won't get turned off unless the configurator explicitly does so. This prevents libproxy from picking up the manual proxy settings. I have unfortunately encountered systems configured exactly like this in the wild.

The current behavior of libproxy is different from e.g. Edge or Chrome in this regard (which do try all options if enabled and if necessary). My expectation for a Windows application using system proxy settings would be for it to behave in the same manner as the built-in browser.

For reference, this is what the settings GUI looks like (on Windows 10):

Note how all options can be enabled.

So we talked about this internally and we agreed to follow the system logic then. Will merge it.