Use _strnicmp on windows#1686
Closed
LeonarddeR wants to merge 2 commits into
Closed
Conversation
Member
|
I think the real fix is probably to use the strncasecmp module from gnulib |
Member
|
But that is more involved |
Member
Author
|
Basically everything I can find on the web suggests using _strnicmp instead. |
Member
|
I think #1688 should solve this in a battle-tested way |
Member
Author
|
Thanks! |
5 tasks
seanbudd
pushed a commit
to nvaccess/nvda
that referenced
this pull request
Dec 4, 2024
Update to liblouis 3.32 Description of user facing changes None Description of development approach Update submodule In this version, a dependency on Gnulib was introduced that doesn't build on Windows. See NMAKE on Windows is broken liblouis/liblouis#1689 . I fixed this using the approach from Use _strnicmp on windows liblouis/liblouis#1686. In short, rather than posix strncasecmp, we use _strnicmp . Testing strategy: Unit tests, running from source Known issues with pull request: Based on the second point as noted below development approach, an alternative could be just removing the metadata part from our liblouis build, which can be used by simply commenting out 'metadata.c' from sconscript.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On windows, strncasecmp is not available. _strnicmp should be functionally equivalent.
cc @bertfrees @egli
fixes #1685