Skip to content

Add the gnulib module strncasecmp#1688

Merged
egli merged 1 commit into
masterfrom
feature/strncasecmp
Dec 3, 2024
Merged

Add the gnulib module strncasecmp#1688
egli merged 1 commit into
masterfrom
feature/strncasecmp

Conversation

@egli

@egli egli commented Dec 3, 2024

Copy link
Copy Markdown
Member

which was used implicitely in metadata.c. Now it is used explicitely (using #include <strings.h>) and the gnulib module should make sure it also works on windows.

This should fix #1685

which was used implicitely in metadata.c. Now it is used
explicitely (using #include <strings.h>) and the gnulib module should
make sure it also works on windows.
@egli egli added this to the 3.32 milestone Dec 3, 2024
@egli egli requested a review from bertfrees December 3, 2024 08:02
@egli egli mentioned this pull request Dec 3, 2024
@LeonarddeR

Copy link
Copy Markdown
Member

It still fails with nmake:

..\liblouis\metadata.c(30,10): fatal error: 'strings.h' file not found 30 | #include <strings.h> | ^~~~~~~~~~~ 1 error generated.

@egli

egli commented Dec 3, 2024

Copy link
Copy Markdown
Member Author

That is interesting. Are you running ./autogen.sh and ./configure?

@LeonarddeR

Copy link
Copy Markdown
Member

That's a step that wasn't necessary with nmake until now. the Nmake part is completely separated from automake/autoconf.

@egli

egli commented Dec 3, 2024

Copy link
Copy Markdown
Member Author

Hm, I just checked the tarball it produces. The tarball only contains strings.in.h which means you'll have to run ./configure to get the strings.h file

@egli

egli commented Dec 3, 2024

Copy link
Copy Markdown
Member Author

At this point I'm unsure what to do. The gnulib module seems the right way to go about this problem, but it is not a solution (at least not immediately) to your build problem.

@LeonarddeR

Copy link
Copy Markdown
Member

I don't think there's a way to run ./configure natively on Windows. May be @dkager has alternative ideas?

@LeonarddeR

Copy link
Copy Markdown
Member

It's not too difficult to solve the build problem for NVDA. We'd have to accept that the current state of Nmake is broken, though.

@egli egli merged commit 64da7f2 into master Dec 3, 2024
@egli egli deleted the feature/strncasecmp branch December 3, 2024 09:12
@LeonarddeR

Copy link
Copy Markdown
Member

Actually, this definitely makes things worse for NVDA. We could suffice with a #define strncasecmp _strnicmp, but now we have to deal with #include <strings.h> that can't be found.

@LeonarddeR

Copy link
Copy Markdown
Member

Never mind, I will just add a strings.h to NVDA that uses the define. That'll work for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nnmake fails to build

3 participants