Add support for free-form triangle shading objects. by alliepiper · Pull Request #157 · libharu/libharu

alliepiper · 2017-05-10T15:26:19Z

We needed the ability to draw polygons with smoothly interpolated vertex colors in VTK, and this patch is sufficient for our needs. Sharing as a MR if anyone else is interested.

Refs #102

mathstuf · 2017-05-10T17:59:06Z

Cc: @opoplawski for Fedora VTK/ParaView packages, libharu will need this patch if VTK is to use the system version. I'll try and find the other distro maintainer github accounts…

mathstuf · 2017-05-10T18:05:06Z

Cc: @lu-zero @domibel @samueljohn @badshah400 (Sorry if my maintainer list is out-of-date.)

lu-zero · 2017-05-10T18:33:47Z

I'm not really the person keeping vtk up in Gentoo, the sci@gentoo.org alias collectively maintains it.

badshah400 · 2017-05-10T19:26:19Z

@mathstuf Thanks for the ping. I will get this patch into openSUSE's packages.

mathstuf

High-level overview only; I don't know enough about the spec to review the rest.

mathstuf · 2017-05-11T11:24:11Z

src/hpdf_pages.c

+    /* search shading-object from shading-resource */
+    key = HPDF_Dict_GetKeyByObj (attr->shadings, shading);
+    if (!key) {
+        /* if the shading is not resisterd in shadings resource, register


"resisters" -> "registered"

Ah, yeah. I copy/pasted that bit from somewhere else. I'll clean up the other instances too.

mathstuf · 2017-05-11T11:25:57Z

src/hpdf_shading.c

+  return HPDF_TRUE;
+}
+
+static void UINT32Swap (HPDF_UINT32  *value)


I thought there was a C standard header which provided these functions.

mathstuf · 2017-05-11T11:28:03Z

src/hpdf_shading.c

+  HPDF_DOUBLE norm = (x - xMin) / (xMax - xMin);
+  HPDF_DOUBLE max = (HPDF_DOUBLE)(0xFFFFFFFF);
+  HPDF_UINT32 enc = (HPDF_UINT32)(norm * max);
+  UINT32Swap(&enc);


Or maybe this should be "make into big endian order" like the pton family. Does this swap need to happen on big endian architectures?

This would be htonl (host-to-network-long), conforming to POSIX.1-2001

alliepiper · 2017-05-11T12:49:10Z

The byteswap thing follows the same pattern used other places in the libharu code, so I just went for consistency. If a libharu dev has an issue with this bit I can rework it, but until there's a problem I think this is good enough for us. I don't think we're targeting any BE archs anyway, so it's not worth the trouble (especially since this project appears to be abandoned -- I get the feeling that this patch will live as an MR forever ;) )

mathstuf · 2017-05-11T13:11:26Z

OK, I'd suggest opening an issue. I know that at least Debian targets BE architectures, but I don't know how much libharu or VTK is used on those.

utkarshayachit · 2017-05-12T17:05:01Z

src/hpdf_shading.c

+
+  HPDF_Real r;
+
+  for (int i = 0; i < 4; ++i)


for (int ..) not allowed in C code.

Well, it's allowed in "newer" C code (C99), but I guess libharu uses an older standard of C?

Most versions of MSVC barely support C99 (if they support it at all), so we're more or less stuck with pre-C99 standards until we stop caring about MSVC < 2015 ;-)

They support this much (because it's part of the C++ standard). The complainer in ParaView was actually an older GCC which doesn't default to C99 without a flag :) .

zhouzhanke · 2018-04-24T03:19:23Z

does this patch has API reference or examples? work for days, still didn't figure out how to use it

alliepiper · 2018-04-24T12:59:14Z

The only example of its use that I'm aware of is here. The shadings follows a similar pattern to the other HPDF objects.

zhouzhanke · 2018-04-26T13:11:50Z

thank you for the example.

add shading type 3, function 2,RGB. modify shading type 4, from libharu#157 pull request.

opoplawski · 2019-02-23T16:29:16Z

Is this complete, or still in progress?

alliepiper · 2019-02-23T16:33:53Z

Yes. It's working well enough for our purposes in VTK, and I don't intend to make any more changes to this patch.

VTK requires a patched libharu that is not maintained upstream See libharu/libharu#157

The pull request has languished for more than two year. Some ports (e.g. VTK) rely on the new functionality. See libharu/libharu#157

libharu/libharu#157 libharu/libharu#187

ArchangeGabriel · 2021-11-06T08:11:25Z

There is an issue with this PR when used in VTK, there is a missing symbol export:

/usr/lib/libvtkIOExportPDF.so.1: undefined symbol: HPDF_Shading_AddVertexRGB

This was initially reported against the ArchLinux vtk package, when trying to import the vtk python module: https://bugs.archlinux.org/task/72574

alliepiper · 2021-11-06T13:12:30Z

@ArchangeGabriel I'm no longer actively working on VTK, but they may be interested in fixing this. Can you make sure this gets reported at https://gitlab.kitware.com/vtk/vtk?

ArchangeGabriel · 2021-11-06T13:19:28Z

A colleague investigated the issue, and this is because we were building with autotools instead of CMake (so VTK is not affected). We switched to CMake to solve the issue. I think this should be sufficient for anyone stumbling upon this.

mathstuf · 2021-11-06T13:59:15Z

Ah, that makes sense. @allisonvacanti if you give me access to your fork, I can update the PR directly if there are any changes that need to be made.

alliepiper · 2021-11-06T15:45:42Z

@mathstuf I unfortunately deleted that fork a while ago.

If you'd like to make a new PR under a KW managed account I can close this and update the description to link to the maintained version.

mathstuf · 2021-11-06T18:12:02Z

Ah. I'll make a new PR if there's ever any movement on this. If adding autotools support is going to have just as many crickets…not sure it's the best use of my time.

ArchangeGabriel · 2021-11-06T18:31:52Z

@mathstuf I honestly don’t think it’s worth it, only people ever affected are the ones building ParaView/VTK themselves with external dependencies instead of vendored one, that took the time to patch their libharu to make it suitable for this, and used autotools instead of CMake. If they went as far, they do know about this ticket and should be able to find the information here.

I guess it’s just a coincidence that it went under radar all this time in Arch, but now it’s fixed for us, so I guess this PR can go back to the deadly silence I’ve awoken it from. ;)

mathstuf suggested changes May 11, 2017

View reviewed changes

utkarshayachit reviewed May 12, 2017

View reviewed changes

Add support for free-form triangle Shading objects.

9e8ba2f

albertziegenhagel mentioned this pull request Jan 10, 2018

WIP: [vtk] [libharu] Add VTK-m and all-modules features to VTK, re-enable libharu microsoft/vcpkg#2541

Closed

alliepiper mentioned this pull request Mar 19, 2018

SHFill and Shading support #102

Closed

zhouzhanke added a commit to zhouzhanke/libharu that referenced this pull request May 3, 2018

add shading type 2, function 2,RGB.

cb3f88a

add shading type 3, function 2,RGB. modify shading type 4, from libharu#157 pull request.

chuckatkins pushed a commit to chuckatkins/spack that referenced this pull request Apr 25, 2019

vtk: Use the vendored libharu

7db5d28

VTK requires a patched libharu that is not maintained upstream See libharu/libharu#157

chuckatkins mentioned this pull request Apr 25, 2019

vtk: Use the vendored libharu spack/spack#11293

Merged

ax3l pushed a commit to spack/spack that referenced this pull request Apr 30, 2019

vtk: Use the vendored libharu (#11293)

d2a5a10

VTK requires a patched libharu that is not maintained upstream See libharu/libharu#157

MarcusCalhoun-Lopez added a commit to macports/macports-ports that referenced this pull request Jul 21, 2019

libharu: apply upstream pull request

7adbbcb

The pull request has languished for more than two year. Some ports (e.g. VTK) rely on the new functionality. See libharu/libharu#157

xylar added a commit to xylar/libharu-feedstock that referenced this pull request May 5, 2020

Add two common patches

a8297d2

libharu/libharu#157 libharu/libharu#187

xylar mentioned this pull request May 5, 2020

Add two common patches conda-forge/libharu-feedstock#1

Merged

5 tasks

bramton changed the base branch from master to devel June 11, 2022 13:56

bramton merged commit bd174ad into libharu:devel Jun 11, 2022

bramton mentioned this pull request Jun 24, 2022

Doesn't support gradient colors #64

Closed

ifekonja mentioned this pull request Jul 1, 2022

[libharu] Build error microsoft/vcpkg#25518

Closed

snowman4628 mentioned this pull request Jul 3, 2022

[libharu] build failure - File does not have the expected hash microsoft/vcpkg#25537

Closed

gharwo mentioned this pull request Jan 11, 2023

[entt, libharu, libopensp, minizip, smf, vlpp, vulkan-headers] Fix incorrect versions microsoft/vcpkg#28571

Merged

Conversation

alliepiper commented May 10, 2017

Uh oh!

mathstuf commented May 10, 2017

Uh oh!

mathstuf commented May 10, 2017

Uh oh!

lu-zero commented May 10, 2017

Uh oh!

badshah400 commented May 10, 2017

Uh oh!

mathstuf left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alliepiper commented May 11, 2017

Uh oh!

mathstuf commented May 11, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhouzhanke commented Apr 24, 2018

Uh oh!

alliepiper commented Apr 24, 2018

Uh oh!

zhouzhanke commented Apr 26, 2018

Uh oh!

opoplawski commented Feb 23, 2019

Uh oh!

alliepiper commented Feb 23, 2019

Uh oh!

ArchangeGabriel commented Nov 6, 2021

Uh oh!

alliepiper commented Nov 6, 2021

Uh oh!

ArchangeGabriel commented Nov 6, 2021

Uh oh!

mathstuf commented Nov 6, 2021

Uh oh!

alliepiper commented Nov 6, 2021

Uh oh!

mathstuf commented Nov 6, 2021

Uh oh!

ArchangeGabriel commented Nov 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants