Skip to content

vtk: Use the vendored libharu#11293

Merged
ax3l merged 1 commit intospack:developfrom
chuckatkins:vtk-use-vendored-libharu
Apr 30, 2019
Merged

vtk: Use the vendored libharu#11293
ax3l merged 1 commit intospack:developfrom
chuckatkins:vtk-use-vendored-libharu

Conversation

@chuckatkins
Copy link
Copy Markdown

VTK requires a patched libharu that is not maintained upstream
See libharu/libharu#157

VTK requires a patched libharu that is not maintained upstream
See libharu/libharu#157
@chuckatkins
Copy link
Copy Markdown
Author

@ax3l from this, it looks like wt is the only other package that still depends on libharu. Is it worth keeping the libharu package around just for the wt variant given that it's not really maintained anymore?

Copy link
Copy Markdown
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me.
Yes, let's keep it around since wt does not vendor it. I will take a look at wt again and check if we might want to make pdf support non-default if it is known to cause issues.

(Update: libharu still builds decently for me on Debian 9, we can make it non-default if someone reports issues with wt.)

@ax3l ax3l merged commit d2a5a10 into spack:develop Apr 30, 2019
@chuckatkins chuckatkins deleted the vtk-use-vendored-libharu branch May 31, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants