Skip to content

Improve small number writing in HPDF_FToA.#187

Merged
bramton merged 1 commit intolibharu:develfrom
alliepiper:FToA_precision
Jun 12, 2022
Merged

Improve small number writing in HPDF_FToA.#187
bramton merged 1 commit intolibharu:develfrom
alliepiper:FToA_precision

Conversation

@alliepiper
Copy link
Copy Markdown

This was truncating all numbers at 1e-5, now it ensures that 5
significant figures will always be written for values > 1e-20.

This was truncating all numbers at 1e-5, now it ensures that 5
significant figures will always be written for values > 1e-20.
xylar added a commit to xylar/libharu-feedstock that referenced this pull request May 5, 2020
@bramton bramton changed the base branch from master to devel June 12, 2022 13:33
@bramton bramton merged commit eb79376 into libharu:devel Jun 12, 2022
@zboszor
Copy link
Copy Markdown

zboszor commented Jul 4, 2022

This patch breaks PDF output for https://github.com/SICOM/rlib
Confirmed by rebuilding the libharu package as supplied by Fedora 36 without this patch.

@bramton
Copy link
Copy Markdown
Member

bramton commented Jul 4, 2022

Hi zbosor, could you provide a bit more background information? What kind of error are you getting? Coud you provide a minimal working example?

@zboszor
Copy link
Copy Markdown

zboszor commented Jul 4, 2022

Hi @bramton , I can't give you a small-ish example.

But this report example: https://github.com/SICOM/rlib/blob/master/src/examples/php/graph.php

which exercises some graphing features of RLIB (pie chart, line chart, etc.) comes out empty with the patch applied to libharu and the expected output with the patch reverted if the report output was PDF. The HTML output where the chart images are generated by GD was correct.

EDIT: The current maintenance branch of RLIB that uses libharu is rlib-2.0.21-RLIB-22-GCC-6-fix

@Nekto89
Copy link
Copy Markdown

Nekto89 commented Dec 9, 2022

this is probably the change that broke this line in my case
image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants