Conversation
Contributor
|
I had idly wondered (in light of e.g. #9559 or other drive-by import minimisation) if there was such a bug. This is great news, I look forward to the actual adjusting PR! |
Contributor
|
bors d+ |
Contributor
|
✌️ digama0 can now approve this pull request. To approve and merge a pull request, simply reply with |
|
This PR/issue depends on:
|
riccardobrasca
pushed a commit
that referenced
this pull request
Jan 19, 2024
Contributor
|
What about merging master, fixing the conflict, and then sending this one to bors (it has already been approved by Scott)? I expect the longer you wait, the more painful it will get. |
Contributor
|
I've merged master and fixed the conflict, re-minimising imports there by hand. bors merge |
Contributor
|
👎 Rejected by label |
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 23, 2024
- [ ] depends on: #9830 This is the `noshake.json` file corresponding to the edits in leanprover-community/batteries#533. There was a small bug in `shake` making it much more conservative than it needed to be, so there is a big mathlib PR #9830, on which this PR depends because CI will not pass without it. Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
shake bug, improve noshake.json generationshake bug, improve noshake.json generation
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 23, 2024
Some of these are already transitively imported, others aren't used at all (but not handled by noshake in #9772). Mostly I wanted to avoid needing all of algebra imported (but unused!) in `FilteredColimitCommutesFiniteLimit`; there are now some `assert_not_exists` to preserve this. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the
noshake.jsonfile corresponding to the edits in leanprover-community/batteries#533. There was a small bug inshakemaking it much more conservative than it needed to be, so there is a big mathlib PR #9830, on which this PR depends because CI will not pass without it.