Skip to content

[Merged by Bors] - chore: minimize some imports#9559

Closed
grunweg wants to merge 7 commits intomasterfrom
MR-minimize-imports
Closed

[Merged by Bors] - chore: minimize some imports#9559
grunweg wants to merge 7 commits intomasterfrom
MR-minimize-imports

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jan 8, 2024

Started from Algebra/Periodic.lean with some snowball sampling. Seems to be somewhat disjoint from the tree shaking in #9347.

@grunweg grunweg added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jan 8, 2024
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jan 8, 2024
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 9, 2024

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Jan 9, 2024
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jan 9, 2024

Thank you for the fast review.
bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jan 9, 2024
Started from Algebra/Periodic.lean with some snowball sampling. Seems to be somewhat disjoint from the tree shaking in #9347.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: minimize some imports [Merged by Bors] - chore: minimize some imports Jan 9, 2024
@mathlib-bors mathlib-bors bot closed this Jan 9, 2024
@mathlib-bors mathlib-bors bot deleted the MR-minimize-imports branch January 9, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants