Skip to content

feat: remove unnecessary imports#9347

Closed
digama0 wants to merge 8 commits intomasterfrom
apply_shake
Closed

feat: remove unnecessary imports#9347
digama0 wants to merge 8 commits intomasterfrom
apply_shake

Conversation

@digama0
Copy link
Copy Markdown
Member

@digama0 digama0 commented Dec 30, 2023

This applies the lake exe shake tool to remove all unused imports in mathlib.


Open in Gitpod

@ghost ghost added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Dec 30, 2023
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 5, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 9, 2024
Started from Algebra/Periodic.lean with some snowball sampling. Seems to be somewhat disjoint from the tree shaking in #9347.
@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 14, 2024
@urkud
Copy link
Copy Markdown
Member

urkud commented Jan 14, 2024

What do you think about merging this part without waiting for a review of the meta code?
UPD: I created #9749 by running git diff shake..apply_shake| patch -p1.

urkud added a commit that referenced this pull request Jan 14, 2024
cherry-picked from #9347
mathlib-bors bot pushed a commit that referenced this pull request Jan 15, 2024
cherry-picked from #9347

Co-Authored-By: @digama0
@ghost ghost removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jan 15, 2024
@ghost
Copy link
Copy Markdown

ghost commented Jan 15, 2024

This PR/issue depends on:

@digama0
Copy link
Copy Markdown
Member Author

digama0 commented Jan 15, 2024

Superceded by #9749

@digama0 digama0 closed this Jan 15, 2024
linesthatinterlace pushed a commit that referenced this pull request Jan 16, 2024
cherry-picked from #9347

Co-Authored-By: @digama0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants