Conversation
1 task
eric-wieser
reviewed
Dec 30, 2023
eric-wieser
reviewed
Dec 30, 2023
eric-wieser
reviewed
Dec 31, 2023
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 15, 2024
This adds the `lake exe shake` command, which will check that every import is used in some constant. This has some known false positives because dependencies on notations and tactics are not tracked, so the `noshake.json` file is used to indicate that a file should always be treated as used, or that specific imports in specific files are treated as used. Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Yury G. Kudryashov <urkud@urkud.name> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
lake exe shake tree shaking toollake exe shake tree shaking tool
linesthatinterlace
pushed a commit
that referenced
this pull request
Jan 16, 2024
This adds the `lake exe shake` command, which will check that every import is used in some constant. This has some known false positives because dependencies on notations and tactics are not tracked, so the `noshake.json` file is used to indicate that a file should always be treated as used, or that specific imports in specific files are treated as used. Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Yury G. Kudryashov <urkud@urkud.name> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
lake exe shakecommand, which will check that every import is used in some constant. This has some known false positives because dependencies on notations and tactics are not tracked, so thenoshake.jsonfile is used to indicate that a file should always be treated as used, or that specific imports in specific files are treated as used.