Merged
Conversation
Collaborator
Author
|
@digama0, do you know why |
Member
|
Uh oh, there was a bug which after fixing is generating loads more shake reports... |
Collaborator
Author
|
Good news! :-) |
fgdorais
approved these changes
Jan 16, 2024
Member
|
I pushed the results of the shake report to this branch. I'll make a PR separately to mathlib with the noshake.json changes for std, such that running |
1 task
joehendrix
approved these changes
Jan 16, 2024
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 23, 2024
- [ ] depends on: #9830 This is the `noshake.json` file corresponding to the edits in leanprover-community/batteries#533. There was a small bug in `shake` making it much more conservative than it needed to be, so there is a big mathlib PR #9830, on which this PR depends because CI will not pass without it. Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
fgdorais
pushed a commit
to fgdorais/batteries
that referenced
this pull request
Feb 18, 2024
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
fgdorais
pushed a commit
to fgdorais/batteries
that referenced
this pull request
Feb 18, 2024
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce imports.