Skip to content

[Merged by Bors] - feat: some lemmas on permutation#9359

Closed
AntoineChambert-Loir wants to merge 135 commits intomasterfrom
ACL/ConjClassCount
Closed

[Merged by Bors] - feat: some lemmas on permutation#9359
AntoineChambert-Loir wants to merge 135 commits intomasterfrom
ACL/ConjClassCount

Conversation

@AntoineChambert-Loir
Copy link
Copy Markdown
Collaborator

@AntoineChambert-Loir AntoineChambert-Loir commented Dec 30, 2023

@AntoineChambert-Loir AntoineChambert-Loir added WIP Work in progress t-algebra Algebra (groups, rings, fields, etc) labels Dec 30, 2023
@AntoineChambert-Loir AntoineChambert-Loir added awaiting-review and removed WIP Work in progress labels Dec 31, 2023
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 6, 2024
@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 8, 2024
@jcommelin
Copy link
Copy Markdown
Member

I pushed a bunch of golfing and cleanup of the first ~600 lines to jmc-ConjClassCount. I hope the diff is useful to you.

I think those first ~600 lines of this PR could make a good standalone PR.

Copy link
Copy Markdown
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I always say the same thing, but it seems to me there is an easy way of splitting the PR:

  • you modify three files
  • new file 1
  • new file 2

What do you think?

@AntoineChambert-Loir
Copy link
Copy Markdown
Collaborator Author

@riccardobrasca : I just did what you suggested, there are now two subsequent PR, #17046 and #17047 .

Copy link
Copy Markdown
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 23, 2024

✌️ AntoineChambert-Loir can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Sep 23, 2024
@riccardobrasca
Copy link
Copy Markdown
Member

@AntoineChambert-Loir this is almost ready to go. Can you please take into account the last comments? Thanks!

Co-authored-by: Eric Wieser <efw@google.com>
Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
Co-authored-by: Eric Wieser <efw@google.com>
Co-authored-by: Eric Wieser <efw@google.com>
@AntoineChambert-Loir
Copy link
Copy Markdown
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Sep 27, 2024
This PR prepares the way to PR #17046 and #17047 which compute the centralizer of a permutation
in a permutation group and in the alternating group.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 27, 2024

Build failed:

@AntoineChambert-Loir
Copy link
Copy Markdown
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Sep 27, 2024
This PR prepares the way to PR #17046 and #17047 which compute the centralizer of a permutation
in a permutation group and in the alternating group.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 27, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: some lemmas on permutation [Merged by Bors] - feat: some lemmas on permutation Sep 27, 2024
@mathlib-bors mathlib-bors bot closed this Sep 27, 2024
@mathlib-bors mathlib-bors bot deleted the ACL/ConjClassCount branch September 27, 2024 14:46
fbarroero pushed a commit that referenced this pull request Oct 2, 2024
This PR prepares the way to PR #17046 and #17047 which compute the centralizer of a permutation
in a permutation group and in the alternating group.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants