Skip to content

[Merged by Bors] - feat: several results on permutations, cycles, etc#17046

Closed
AntoineChambert-Loir wants to merge 149 commits intomasterfrom
ACL/ConjClassCount-2
Closed

[Merged by Bors] - feat: several results on permutations, cycles, etc#17046
AntoineChambert-Loir wants to merge 149 commits intomasterfrom
ACL/ConjClassCount-2

Conversation

@AntoineChambert-Loir
Copy link
Copy Markdown
Collaborator

@AntoineChambert-Loir AntoineChambert-Loir commented Sep 23, 2024

These are basic results on permutations which will be useful for PR #17522 and #17047 which
study the centralizer of a permutation.


Open in Gitpod

fbarroero pushed a commit that referenced this pull request Oct 2, 2024
This PR prepares the way to PR #17046 and #17047 which compute the centralizer of a permutation
in a permutation group and in the alternating group.
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 6, 2024
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Oct 7, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 7, 2024
@AntoineChambert-Loir AntoineChambert-Loir changed the title feat(GroupTheory/Perm/Centralizer): compute the centralizer of a permutation feat: several results on permutations, cycles, etc Oct 7, 2024
@AntoineChambert-Loir AntoineChambert-Loir removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 9, 2024
@AntoineChambert-Loir
Copy link
Copy Markdown
Collaborator Author

I have removed the main new part to another PR (#17522). The present PR consists of basic useful lemmas.

@AntoineChambert-Loir
Copy link
Copy Markdown
Collaborator Author

I don't understand what the large-import tag means, because it doesn't seem I have modified imports.

@ADedecker
Copy link
Copy Markdown
Member

I don't understand what the large-import tag means, because it doesn't seem I have modified imports.

This comment by the bot (which gets updated on each commit) tells you precisely which imports changed (and indeed you add an import in GroupTheory.Perm.Support). In this case I think the import is completely sensible, so no worries (unlike the red color might suggest, this tag is meant to attract attention, not block a PR).

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 22, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 28, 2024
Copy link
Copy Markdown
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

(MulAction.stabilizer (ConjAct G) g) := by
ext k
simp only [mem_centralizer_iff, Set.mem_singleton_iff, forall_eq, ConjAct.toConjAct_smul]
rw [eq_comm]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check (quickly) if the need for rw [eq_comm] is caused by a lemma written in a way different wrt to the others?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By mem_centralizer_iff, k belongs to the centralizer of {g} means g * k = k * g, while k belongs to the stabilizer of g by the conjugation action means that k * g * k^{-1} = g.
It probably makes sense to rephrase mem_centralizer_iff in the opposite direction. (But please let
me do that elsewhere!)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, no problem.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let a note that maybe we should do that sometime.

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 6, 2024

✌️ AntoineChambert-Loir can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 6, 2024
@AntoineChambert-Loir
Copy link
Copy Markdown
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Nov 6, 2024
These are basic results on permutations which will be useful for PR #17522 and  #17047 which
study the centralizer of a permutation. 



Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 6, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: several results on permutations, cycles, etc [Merged by Bors] - feat: several results on permutations, cycles, etc Nov 6, 2024
@mathlib-bors mathlib-bors bot closed this Nov 6, 2024
@mathlib-bors mathlib-bors bot deleted the ACL/ConjClassCount-2 branch November 6, 2024 18:00
TobiasLeichtfried pushed a commit that referenced this pull request Nov 21, 2024
These are basic results on permutations which will be useful for PR #17522 and  #17047 which
study the centralizer of a permutation. 



Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). large-import Automatically added label for PRs with a significant increase in transitive imports t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants