Feat(Algebra/Order/BigOperators/Ring/Multiset): delete duplicate lemmas#16775
Closed
AntoineChambert-Loir wants to merge 7 commits intomasterfrom
Closed
Feat(Algebra/Order/BigOperators/Ring/Multiset): delete duplicate lemmas#16775AntoineChambert-Loir wants to merge 7 commits intomasterfrom
AntoineChambert-Loir wants to merge 7 commits intomasterfrom
Conversation
PR summary 329a046939Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
remove a modificaion that hat nothing to do with the PR
4 tasks
Member
|
I don't see any deleted lemmas, only assumptions moved to |
Collaborator
Author
|
I don't understand what happened. I had the certainty of having deleted lemmas. Possibly, I just deleted lemmas from #9359 that I had written myself while believing they were from mathlib, thus essentially bringing the file to its initial state. I think I can close this branch here. Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete lemmas for
Ringthat follow from analogous ones in Mathlib.Algebra.Order.BigOperators.GroupWithZero.Multiset(Despite the name of the imported file, they work for
CommMonoidWithZero)