[Merged by Bors] - fix: weaken typeclass required for evalAdd in positivity#34133
Closed
fpvandoorn wants to merge 2 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - fix: weaken typeclass required for evalAdd in positivity#34133fpvandoorn wants to merge 2 commits intoleanprover-community:masterfrom
fpvandoorn wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
PR summary f72b361431Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
grunweg
reviewed
Jan 19, 2026
Contributor
|
Thanks for the quick investigation and fix! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 19, 2026
Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
fpvandoorn
pushed a commit
to fpvandoorn/carleson
that referenced
this pull request
Jan 19, 2026
* Original motivation: can leanprover-community/mathlib4#34023 be used to golf some proofs? * When leanprover-community/mathlib4#34039 (`finiteness [h, h']` syntax) is merged, it will also be interesting to try using it more. * And leanprover-community/mathlib4#34133 (positivity bugfix) might also help with using positivity/finiteness more. --------- Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
goliath-klein
pushed a commit
to PrParadoxy/mathlib4
that referenced
this pull request
Jan 24, 2026
…community#34133) Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Adding.20superfluous.20hypotheses.20makes.20positivity.20fail/with/568774307