[Merged by Bors] - feat(finiteness): support finiteness [h, h'] syntax#34039
Closed
grunweg wants to merge 8 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat(finiteness): support finiteness [h, h'] syntax#34039grunweg wants to merge 8 commits intoleanprover-community:masterfrom
finiteness [h, h'] syntax#34039grunweg wants to merge 8 commits intoleanprover-community:masterfrom
Conversation
…heses And slightly rewrite the doc-strings to conform more closely to the guidelines.
Also include tests for using aesop clauses and finiteness?.
Contributor
Author
|
@fpvandoorn We discussed this briefly. @Vierkantor in case you'd like to look at the new doc-string formatting (entirely optional --- but it would be good to land this PR before polishing |
PR summary d498a88e35Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
grunweg
commented
Jan 19, 2026
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
Contributor
Author
|
Thanks for the review! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 19, 2026
This PR adds support for the `finiteness [h, h']` syntax. This can be combined with the existing versions, such as supporting aesop clauses or the `finiteness?` and `finiteness_nonterminal` variants. This allows golfing mathlib in a few places. While adding tests, we take the opportunity to also test `finiteness?` and adding aesop clauses: these were previously untested. We also improve the tactic doc-string slightly: making it fully confirm to the new style guidelines is left for a future PR. This PR is inspired by #30388.
fpvandoorn
pushed a commit
to fpvandoorn/carleson
that referenced
this pull request
Jan 19, 2026
* Original motivation: can leanprover-community/mathlib4#34023 be used to golf some proofs? * When leanprover-community/mathlib4#34039 (`finiteness [h, h']` syntax) is merged, it will also be interesting to try using it more. * And leanprover-community/mathlib4#34133 (positivity bugfix) might also help with using positivity/finiteness more. --------- Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 19, 2026
This PR adds support for the `finiteness [h, h']` syntax. This can be combined with the existing versions, such as supporting aesop clauses or the `finiteness?` and `finiteness_nonterminal` variants. This allows golfing mathlib in a few places. While adding tests, we take the opportunity to also test `finiteness?` and adding aesop clauses: these were previously untested. We also improve the tactic doc-string slightly: making it fully confirm to the new style guidelines is left for a future PR. This PR is inspired by #30388.
Member
|
bors r- |
Contributor
|
Canceled. |
Contributor
Author
|
CI passes, and this PR state was essentially approved by Floris (except for a suggestion which sadly didn't work; I'll obviously be happy to fix it in a follow-up PR). Let me go ahead and bors it: |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 19, 2026
This PR adds support for the `finiteness [h, h']` syntax. This can be combined with the existing versions, such as supporting aesop clauses or the `finiteness?` and `finiteness_nonterminal` variants. This allows golfing mathlib in a few places. While adding tests, we take the opportunity to also test `finiteness?` and adding aesop clauses: these were previously untested. We also improve the tactic doc-string slightly: making it fully confirm to the new style guidelines is left for a future PR. This PR is inspired by #30388.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
finiteness [h, h'] syntaxfiniteness [h, h'] syntax
goliath-klein
pushed a commit
to PrParadoxy/mathlib4
that referenced
this pull request
Jan 24, 2026
…munity#34039) This PR adds support for the `finiteness [h, h']` syntax. This can be combined with the existing versions, such as supporting aesop clauses or the `finiteness?` and `finiteness_nonterminal` variants. This allows golfing mathlib in a few places. While adding tests, we take the opportunity to also test `finiteness?` and adding aesop clauses: these were previously untested. We also improve the tactic doc-string slightly: making it fully confirm to the new style guidelines is left for a future PR. This PR is inspired by leanprover-community#30388.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
finiteness [h, h']syntax. This can be combined with the existing versions, such as supporting aesop clauses or thefiniteness?andfiniteness_nonterminalvariants. This allows golfing mathlib in a few places.While adding tests, we take the opportunity to also test
finiteness?and adding aesop clauses: these were previously untested. We also improve the tactic doc-string slightly: making it fully confirm to the new style guidelines is left for a future PR.This PR is inspired by #30388.