[Merged by Bors] - feat: push for Set membership#34023
Closed
JovanGerb wants to merge 2 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat: push for Set membership#34023JovanGerb wants to merge 2 commits intoleanprover-community:masterfrom
push for Set membership#34023JovanGerb wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
PR summary 2b4c6152f1Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Order.Interval.Set.Defs | 74 | 76 | +2 (+2.70%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Order.Interval.Set.Defs |
2 |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Contributor
|
Thank you for splitting this out! This PR looks good to me --- if you fix the merge conflict, I'll merge it! |
Contributor
|
Thanks! |
Contributor
|
✌️ JovanGerb can now approve this pull request. To approve and merge a pull request, simply reply with |
|
As this PR is labelled bors merge |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
push for Set membershippush for Set membership
eliasjudin
pushed a commit
to eliasjudin/mathlib4
that referenced
this pull request
Jan 18, 2026
This PR adds `@[push]` tags for set membership. This is a subset of leanprover-community#30042, namely all the `Set` tags. leanprover-community#30042 also has tags for `Finset` and `Multiset`; as `Set` is the biggest use case of these, we start with just these.
bilichboris
pushed a commit
to bilichboris/mathlib4
that referenced
this pull request
Jan 18, 2026
This PR adds `@[push]` tags for set membership. This is a subset of leanprover-community#30042, namely all the `Set` tags. leanprover-community#30042 also has tags for `Finset` and `Multiset`; as `Set` is the biggest use case of these, we start with just these.
fpvandoorn
pushed a commit
to fpvandoorn/carleson
that referenced
this pull request
Jan 19, 2026
* Original motivation: can leanprover-community/mathlib4#34023 be used to golf some proofs? * When leanprover-community/mathlib4#34039 (`finiteness [h, h']` syntax) is merged, it will also be interesting to try using it more. * And leanprover-community/mathlib4#34133 (positivity bugfix) might also help with using positivity/finiteness more. --------- Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
goliath-klein
pushed a commit
to PrParadoxy/mathlib4
that referenced
this pull request
Jan 24, 2026
This PR adds `@[push]` tags for set membership. This is a subset of leanprover-community#30042, namely all the `Set` tags. leanprover-community#30042 also has tags for `Finset` and `Multiset`; as `Set` is the biggest use case of these, we start with just these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
@[push]tags for set membership. This is a subset of #30042, namely all theSettags.#30042 also has tags for
FinsetandMultiset; asSetis the biggest use case of these, we start with just these.