Skip to content

[Merged by Bors] - feat(RingTheory): lemmas on finiteness of LinearMap and Module.End#24015

Closed
alreadydone wants to merge 20 commits intomasterfrom
Finite_Module.End
Closed

[Merged by Bors] - feat(RingTheory): lemmas on finiteness of LinearMap and Module.End#24015
alreadydone wants to merge 20 commits intomasterfrom
Finite_Module.End

Conversation

@alreadydone
Copy link
Copy Markdown
Contributor

@alreadydone alreadydone commented Apr 13, 2025


One less lemma than #24012, but with the advantage of not depending on #23963.

Open in Gitpod

@alreadydone alreadydone added the t-algebra Algebra (groups, rings, fields, etc) label Apr 13, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 13, 2025

PR summary e756471e49

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance (priority := 50) [SMul T M] [SMulMemClass S T M] [SMulCommClass T R M] :
+ instance (priority := 50) [SMulCommClass M N α] : SMulCommClass M N s
+ instance (priority := 50) [SMulCommClass N M α] : SMulCommClass N M s
+ instance [IsSemisimpleModule R M] : Module.Finite R₀ (P →ₗ[R] m)
+ instance [IsSemisimpleModule R M] : Module.Finite R₀ (m →ₗ[R] P)
+ instance [Module.Finite R M] : Module.Finite R Mᵐᵒᵖ := equiv (MulOpposite.opLinearEquiv R)
+ of_isComplemented_codomain
+ of_isComplemented_domain
+ surjective_comp_linearProjOfIsCompl
+ surjective_comp_subtype_of_isComplemented

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Apr 16, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

This PR/issue depends on:

@ghost
Copy link
Copy Markdown

ghost commented Apr 17, 2025

!bench

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit 875ca65.
There were no significant changes against commit d4fc037.

@github-actions
Copy link
Copy Markdown

File Instructions %
build +16.598⬝10⁹ (+0.01%)
Mathlib.GroupTheory.GroupAction.SubMulAction +4.551⬝10⁹ (+18.01%)
2 files, Instructions +2.0⬝10⁹
File Instructions %
Mathlib.RingTheory.Finiteness.Basic +2.732⬝10⁹ (+14.93%)
Mathlib.RingTheory.SimpleModule.Basic +2.674⬝10⁹ (+3.82%)
2 files, Instructions +1.0⬝10⁹
File Instructions %
Mathlib.LinearAlgebra.Projection +1.586⬝10⁹ (+2.65%)
Mathlib.LinearAlgebra.BilinearMap +1.491⬝10⁹ (+2.26%)

CI run

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 15, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@alreadydone alreadydone removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 16, 2025
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label May 16, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 27, 2025
@alreadydone alreadydone removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 27, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 27, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 27, 2025
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do the changes here interact with #27467 ?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I right in thinking that the changes in this file is just rearranging things, @alreadydone?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention is to generalize certain arguments of lcomp from CommSemiring to Semiring, but in order to reuse lcompₛₗ I have to reorder things.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. @eric-wieser, I don't think there are any interactions between #27467 and this. Only llcomp is moved and semi-linearized there, the rest is untouched.

@grunweg grunweg added t-ring-theory Ring theory and removed t-algebra Algebra (groups, rings, fields, etc) labels Aug 5, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 13, 2025
@alreadydone alreadydone removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 14, 2025
@jcommelin
Copy link
Copy Markdown
Member

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Sep 4, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 4, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory): lemmas on finiteness of LinearMap and Module.End [Merged by Bors] - feat(RingTheory): lemmas on finiteness of LinearMap and Module.End Sep 4, 2025
@mathlib-bors mathlib-bors bot closed this Sep 4, 2025
@mathlib-bors mathlib-bors bot deleted the Finite_Module.End branch September 4, 2025 12:41
yuanyi-350 pushed a commit to yuanyi-350/yuanyi_mathlib4 that referenced this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants