Skip to content

[Merged by Bors] - chore(LinearAlgebra/BilinearMap): semi-linearize#27467

Closed
themathqueen wants to merge 12 commits intoleanprover-community:masterfrom
themathqueen:chore_semilinear_bilinear
Closed

[Merged by Bors] - chore(LinearAlgebra/BilinearMap): semi-linearize#27467
themathqueen wants to merge 12 commits intoleanprover-community:masterfrom
themathqueen:chore_semilinear_bilinear

Conversation

@themathqueen
Copy link
Copy Markdown
Collaborator

@themathqueen themathqueen commented Jul 25, 2025

Semi-linearizes llcomp and creates a new definition compr₂ₛₗ for the semi-linear version of compr₂.

Original PRs: #27353 (#27310, #24208).

Co-authored-by: @ADedecker

Open in Gitpod

@themathqueen themathqueen mentioned this pull request Jul 25, 2025
Closed
2 tasks
@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Jul 25, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 25, 2025 •
edited
Loading

PR summary 4870fa4903

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ bijective_compr₂ₛₗ_of_equiv
+ compr₂ₛₗ
+ compr₂ₛₗ_apply
+ injective_compr₂ₛₗ_of_injective
+ surjective_compr₂ₛₗ_of_equiv
+ surjective_compr₂ₛₗ_of_exists_rightInverse

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

j-loreaux
j-loreaux reviewed Jul 26, 2025
View reviewed changes
@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes. label Jul 26, 2025
@themathqueen
Copy link
Copy Markdown
Collaborator Author

themathqueen commented Jul 27, 2025

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jul 27, 2025
j-loreaux
j-loreaux approved these changes Jul 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer delegate

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 27, 2025

🚀 Pull request has been placed on the maintainer queue by j-loreaux.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 27, 2025
themathqueen and others added 2 commits July 27, 2025 22:15
@themathqueen @j-loreaux
Update Mathlib/LinearAlgebra/BilinearMap.lean
3102290 
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@themathqueen @j-loreaux
Update Mathlib/LinearAlgebra/BilinearMap.lean
5942425 
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
eric-wieser
eric-wieser reviewed Jul 27, 2025
View reviewed changes
eric-wieser
eric-wieser reviewed Jul 27, 2025
View reviewed changes
@eric-wieser eric-wieser mentioned this pull request Jul 27, 2025
Closed
1 task
@bryangingechen bryangingechen added the awaiting-author A reviewer has asked the author a question or requested changes. label Jul 28, 2025
@themathqueen
Copy link
Copy Markdown
Collaborator Author

themathqueen commented Jul 28, 2025

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jul 28, 2025
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Aug 13, 2025

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 13, 2025

✌️ themathqueen can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Aug 13, 2025
@ghost ghost removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 13, 2025
@themathqueen
Copy link
Copy Markdown
Collaborator Author

themathqueen commented Aug 13, 2025

bors r+

@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Aug 13, 2025

@themathqueen Did you see that I had two suggestions? I think we should apply these before sending this to bors. These were the reason I delegated rather than sending this to bors myself.

bors r-

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 13, 2025

Canceled.

@ghost ghost removed the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Aug 13, 2025
@themathqueen
Copy link
Copy Markdown
Collaborator Author

themathqueen commented Aug 13, 2025

@ocfnash, you haven't sent the suggestions!

ocfnash
ocfnash approved these changes Aug 13, 2025
View reviewed changes
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Aug 13, 2025 •
edited
Loading

@ocfnash, you haven't sent the suggestions!

Oops sorry I somehow forgot to click "Submit Review" (or possibly GitHub had a hiccup)

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 13, 2025

✌️ themathqueen can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Aug 13, 2025
themathqueen and others added 2 commits August 13, 2025 11:27
@themathqueen @ocfnash
Update Mathlib/LinearAlgebra/BilinearMap.lean
898cdcb 
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
@themathqueen @ocfnash
Update Mathlib/LinearAlgebra/BilinearMap.lean
07bb926 
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
@themathqueen
Copy link
Copy Markdown
Collaborator Author

themathqueen commented Aug 13, 2025

haha thanks @ocfnash, all applied now :)

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Aug 13, 2025
@themathqueen
chore(LinearAlgebra/BilinearMap): semi-linearize (#27467)
bbd1ca8 
Semi-linearizes `llcomp` and creates a new definition `compr₂ₛₗ` for the semi-linear version of `compr₂`.

Original PRs: #27353 (#27310, #24208).

Co-authored-by: @ADedecker



Co-authored-by: themathqueen <23701951+themathqueen@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 13, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(LinearAlgebra/BilinearMap): semi-linearize [Merged by Bors] - chore(LinearAlgebra/BilinearMap): semi-linearize Aug 13, 2025
@mathlib-bors mathlib-bors bot closed this Aug 13, 2025
@themathqueen themathqueen deleted the chore_semilinear_bilinear branch August 13, 2025 12:34
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
@themathqueen @Paul-Lez
chore(LinearAlgebra/BilinearMap): semi-linearize (leanprover-communit…
34101f3 
…y#27467)

Semi-linearizes `llcomp` and creates a new definition `compr₂ₛₗ` for the semi-linear version of `compr₂`.

Original PRs: leanprover-community#27353 (leanprover-community#27310, leanprover-community#24208).

Co-authored-by: @ADedecker



Co-authored-by: themathqueen <23701951+themathqueen@users.noreply.github.com>
pechersky pushed a commit to pechersky/mathlib4 that referenced this pull request Aug 25, 2025
@themathqueen @pechersky
chore(LinearAlgebra/BilinearMap): semi-linearize (leanprover-communit…
ece35f0 
…y#27467)

Semi-linearizes `llcomp` and creates a new definition `compr₂ₛₗ` for the semi-linear version of `compr₂`.

Original PRs: leanprover-community#27353 (leanprover-community#27310, leanprover-community#24208).

Co-authored-by: @ADedecker



Co-authored-by: themathqueen <23701951+themathqueen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@ocfnash ocfnash ocfnash approved these changes

@j-loreaux j-loreaux j-loreaux approved these changes

Assignees

@ocfnash ocfnash

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@themathqueen @ocfnash @eric-wieser @j-loreaux @bryangingechen