Skip to content

[Merged by Bors] - chore(LinearAlgebra/TensorProduct/Basic): more semi-linearizing#27353

Closed
themathqueen wants to merge 46 commits intoleanprover-community:masterfrom
themathqueen:AD_semilinearize_tensor_part1
Closed

[Merged by Bors] - chore(LinearAlgebra/TensorProduct/Basic): more semi-linearizing#27353
themathqueen wants to merge 46 commits intoleanprover-community:masterfrom
themathqueen:AD_semilinearize_tensor_part1

Conversation

@themathqueen
Copy link
Copy Markdown
Collaborator

@themathqueen themathqueen commented Jul 22, 2025

@themathqueen themathqueen marked this pull request as draft July 22, 2025 16:33
@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Jul 22, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 22, 2025

PR summary 69bf692a64

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ lift_compr₂ₛₗ
+ lift_mk_compr₂ₛₗ

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the WIP Work in progress label Jul 22, 2025
@themathqueen themathqueen marked this pull request as ready for review July 22, 2025 18:36
@github-actions github-actions bot removed the WIP Work in progress label Jul 22, 2025
@themathqueen themathqueen changed the title chore(LinearAlgebra/TensorProduct/Basic): semi-linearizing refactor(LinearAlgebra/TensorProduct/Basic): semi-linearizing Jul 22, 2025
@themathqueen themathqueen changed the title refactor(LinearAlgebra/TensorProduct/Basic): semi-linearizing chore(LinearAlgebra/TensorProduct/Basic): semi-linearizing Jul 22, 2025
@themathqueen
Copy link
Copy Markdown
Collaborator Author

To the reviewers: once you deem this ready, please delegate instead of merging. I want to change the docstrings to align with the new changes, but I don't want to do that now because it would create too much noise.

@alreadydone
Copy link
Copy Markdown
Contributor

maintainer delegate

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by alreadydone.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Oct 30, 2025
@jcommelin
Copy link
Copy Markdown
Member

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 30, 2025

✌️ themathqueen can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Oct 30, 2025
@themathqueen
Copy link
Copy Markdown
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Oct 30, 2025
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: ADedecker <anatolededecker@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 30, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(LinearAlgebra/TensorProduct/Basic): more semi-linearizing [Merged by Bors] - chore(LinearAlgebra/TensorProduct/Basic): more semi-linearizing Oct 30, 2025
@mathlib-bors mathlib-bors bot closed this Oct 30, 2025
@themathqueen themathqueen deleted the AD_semilinearize_tensor_part1 branch October 30, 2025 11:52
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Nov 7, 2025
…prover-community#27353)

Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: ADedecker <anatolededecker@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants