[Merged by Bors] - chore: automatically additivize IsScalarTower#24115
Closed
alreadydone wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - chore: automatically additivize IsScalarTower#24115alreadydone wants to merge 4 commits intomasterfrom
alreadydone wants to merge 4 commits intomasterfrom
Conversation
1 task
PR summary 98a206dc87Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
alreadydone
commented
Apr 16, 2025
Comment on lines
1076
to
+1080
| | "Is"::"Of"::"Fin"::"Order"::s => "IsOfFinAddOrder" :: fixAbbreviation s | ||
| | "is" :: "Central" :: "Scalar" :: s => "isCentralVAdd" :: fixAbbreviation s | ||
| | "Is" :: "Central" :: "Scalar" :: s => "IsCentralVAdd" :: fixAbbreviation s | ||
| | "is" :: "Scalar" :: "Tower" :: s => "vaddAssocClass" :: fixAbbreviation s | ||
| | "Is" :: "Scalar" :: "Tower" :: s => "VAddAssocClass" :: fixAbbreviation s |
Contributor
Author
There was a problem hiding this comment.
I'm not sure why we were not simply writing "IsOfFinOrder" etc.
eric-wieser
reviewed
Apr 16, 2025
eric-wieser
reviewed
Apr 16, 2025
Member
eric-wieser
left a comment
There was a problem hiding this comment.
I'd argue that the SMulCommClass instances don't belong in this PR; could you split them out too?
Contributor
Author
|
!bench |
Co-authored-by: Eric Wieser <efw@google.com>
eric-wieser
reviewed
Apr 16, 2025
Collaborator
|
Here are the benchmark results for commit 8a83294. |
|
Contributor
Author
|
Hmm, I intended to bench dd73224. Now I have to do it in another PR ... |
Member
|
bors merge Thanks! |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
tannerduve
pushed a commit
that referenced
this pull request
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.