Skip to content

[Merged by Bors] - chore: forward-port leanprover-community/mathlib#18429#2220

Closed
eric-wieser wants to merge 7 commits intomasterfrom
forward-port-18429
Closed

[Merged by Bors] - chore: forward-port leanprover-community/mathlib#18429#2220
eric-wieser wants to merge 7 commits intomasterfrom
forward-port-18429

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser commented Feb 11, 2023

Also removes a duplicate lemma that was added by accident while porting.
@eric-wieser eric-wieser added needs-mathlib-SHA mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Feb 11, 2023
bors bot pushed a commit to leanprover-community/mathlib3 that referenced this pull request Feb 28, 2023
…18429)

Everything in this file about `multiset.pi.cons` generalizes to `Sort`.
The parts of the file which don't generalize now use `β` instead.

This is motivated by #18417, though I do not know if supporting `Sort` is actually important there.

Forward-ported as leanprover-community/mathlib4#2220
This renames `Finset.pi.cons` to `Finset.Pi.cons` to match `Multiset.Pi.cons`.
@kim-em kim-em added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Mar 1, 2023
@kim-em kim-em removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Mar 1, 2023
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Mar 1, 2023

This PR/issue depends on:

@eric-wieser eric-wieser added awaiting-review and removed awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Mar 2, 2023
Comment on lines -142 to -144
theorem pi.con_ext {m : Multiset α} {a : α} (f : ∀ a' ∈ a ::ₘ m, δ a') :
(Pi.cons m a (f _ (mem_cons_self _ _)) fun a' ha' => f a' (mem_cons_of_mem ha')) = f := by simp

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pi.cons_ext exists immediately above with the same statement; I would guess this was an accidentally-committed test.

@RemyDegenne
Copy link
Copy Markdown
Contributor

Thanks!
bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Mar 19, 2023
bors bot pushed a commit that referenced this pull request Mar 19, 2023
Also removes a duplicate lemma that was added by accident while porting.
@bors
Copy link
Copy Markdown

bors bot commented Mar 19, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Mar 19, 2023
Also removes a duplicate lemma that was added by accident while porting.
@bors
Copy link
Copy Markdown

bors bot commented Mar 19, 2023

Build failed (retrying...):

  • Build

bors bot pushed a commit that referenced this pull request Mar 19, 2023
Also removes a duplicate lemma that was added by accident while porting.
@bors
Copy link
Copy Markdown

bors bot commented Mar 19, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore: forward-port leanprover-community/mathlib#18429 [Merged by Bors] - chore: forward-port leanprover-community/mathlib#18429 Mar 19, 2023
@bors bors bot closed this Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.

Projects

No open projects
Status: SHA added

Development

Successfully merging this pull request may close these issues.

3 participants