Skip to content

[Merged by Bors] - chore: fix naming of Finset.pi.cons#2553

Closed
eric-wieser wants to merge 2 commits intomasterfrom
eric-wieser/fix-Finset.Pi.cons
Closed

[Merged by Bors] - chore: fix naming of Finset.pi.cons#2553
eric-wieser wants to merge 2 commits intomasterfrom
eric-wieser/fix-Finset.Pi.cons

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser commented Mar 1, 2023

This renames Finset.pi.cons to Finset.Pi.cons to match Multiset.Pi.cons.
This doesn't need a backport, as it was just a mistake in the initial port in #1590.


Open in Gitpod

This renames `Finset.pi.cons` to `Finset.Pi.cons` to match `Multiset.Pi.cons`.
@eric-wieser eric-wieser added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Mar 1, 2023
@eric-wieser eric-wieser changed the title chore(data/finset/pi): fix naming chore: fix naming of Finset.pi.cons Mar 1, 2023
@eric-wieser eric-wieser removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Mar 1, 2023
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@kim-em kim-em added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Mar 1, 2023
bors bot pushed a commit that referenced this pull request Mar 1, 2023
This renames `Finset.pi.cons` to `Finset.Pi.cons` to match `Multiset.Pi.cons`.
This doesn't need a backport, as it was just a mistake in the initial port in #1590.
@bors
Copy link
Copy Markdown

bors bot commented Mar 1, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore: fix naming of Finset.pi.cons [Merged by Bors] - chore: fix naming of Finset.pi.cons Mar 1, 2023
@bors bors bot closed this Mar 1, 2023
@bors bors bot deleted the eric-wieser/fix-Finset.Pi.cons branch March 1, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants