This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(data/{multiset,finset}/pi): generalize from Type to Sort#18429
Closed
eric-wieser wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - chore(data/{multiset,finset}/pi): generalize from Type to Sort#18429eric-wieser wants to merge 2 commits intomasterfrom
Type to Sort#18429eric-wieser wants to merge 2 commits intomasterfrom
Conversation
604797b to
01dfdb5
Compare
eric-wieser
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 11, 2023
Also removes a duplicate lemma that was added by accident while porting.
Type to SortType to Sort
YaelDillies
approved these changes
Feb 20, 2023
Collaborator
YaelDillies
left a comment
There was a problem hiding this comment.
Well spotted! This looks reasonable, although we might want to move the material that's generalisable to Sort* before the Type*-specific one.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Member
Author
I thought about that, but that seems more annoying to forward-port (and more importantly, review after forward-porting) |
Collaborator
|
It looks reasonable, but I'd rather let you merge it since I don't know the context w.r.t. mathport. bors d+ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Feb 28, 2023
…18429) Everything in this file about `multiset.pi.cons` generalizes to `Sort`. The parts of the file which don't generalize now use `β` instead. This is motivated by #18417, though I do not know if supporting `Sort` is actually important there. Forward-ported as leanprover-community/mathlib4#2220
|
Pull request successfully merged into master. Build succeeded: |
Type to SortType to Sort
eric-wieser
added a commit
that referenced
this pull request
Mar 1, 2023
This discard the changes from #18429, as these are already present in the new version.
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 19, 2023
Also removes a duplicate lemma that was added by accident while porting.
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 19, 2023
Also removes a duplicate lemma that was added by accident while porting.
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 19, 2023
Also removes a duplicate lemma that was added by accident while porting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything in this file about
multiset.pi.consgeneralizes toSort.The parts of the file which don't generalize now use
βinstead.This is motivated by #18417, though I do not know if supporting
Sortis actually important there.Forward-ported as leanprover-community/mathlib4#2220