Skip to content

[Merged by Bors] - chore: split Mathlib/Algebra/Group/Int#20624

Closed
kim-em wants to merge 13 commits intomasterfrom
split_algebra_group_int
Closed

[Merged by Bors] - chore: split Mathlib/Algebra/Group/Int#20624
kim-em wants to merge 13 commits intomasterfrom
split_algebra_group_int

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Jan 10, 2025

Follows the existing split for Mathlib/Algebra/Group/Nat.

@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Jan 10, 2025

Still needs a shake once oleans are available.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 10, 2025

PR summary bec329d851

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Group.Int 322 0 -322 (-100.00%)
Mathlib.Algebra.Ring.Int.Defs 327 142 -185 (-56.57%)
Mathlib.Algebra.Order.Group.Int 343 194 -149 (-43.44%)
Mathlib.Algebra.Ring.Int.Units 338 234 -104 (-30.77%)
Mathlib.Algebra.Order.Group.Unbundled.Int 362 254 -108 (-29.83%)
Mathlib.Data.Int.GCD 345 303 -42 (-12.17%)
Mathlib.Algebra.Ring.Rat 339 317 -22 (-6.49%)
Mathlib.CategoryTheory.GradedObject 483 459 -24 (-4.97%)
Mathlib.Algebra.GroupPower.IterateHom 334 322 -12 (-3.59%)
Mathlib.Algebra.BigOperators.Group.List.Lemmas 388 379 -9 (-2.32%)
Mathlib.Algebra.Group.Subgroup.ZPowers.Basic 409 403 -6 (-1.47%)
Mathlib.Algebra.EuclideanDomain.Int 370 365 -5 (-1.35%)
Mathlib.GroupTheory.FreeGroup.Basic 423 418 -5 (-1.18%)
Mathlib.Data.Finset.Image 442 437 -5 (-1.13%)
Mathlib.Data.Fintype.Basic 448 444 -4 (-0.89%)
Mathlib.Data.Fintype.Parity 459 456 -3 (-0.65%)
Mathlib.Algebra.BigOperators.Group.Finset 510 507 -3 (-0.59%)
Mathlib.Data.Int.NatPrime 380 379 -1 (-0.26%)
Import changes for all files
Files Import difference
There are 3626 files with changed transitive imports taking up over 155751 characters: this is too many to display!
You can run scripts/import_trans_difference.sh all locally to see the whole output.

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Jan 10, 2025
@github-actions github-actions bot removed the large-import Automatically added label for PRs with a significant increase in transitive imports label Jan 10, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 10, 2025
@mattrobball
Copy link
Copy Markdown
Contributor

bors delegate+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 10, 2025

✌️ kim-em can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 10, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 10, 2025
@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Jan 11, 2025

Just checking, @mattrobball, is there some reason you delegated rather than merged? I don't see anything outstanding, and I think CI was already complete.

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 11, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 11, 2025
Follows the existing split for `Mathlib/Algebra/Group/Nat`.

Co-authored-by: Matthew Ballard <matt@mrb.email>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 11, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: split Mathlib/Algebra/Group/Int [Merged by Bors] - chore: split Mathlib/Algebra/Group/Int Jan 11, 2025
@mathlib-bors mathlib-bors bot closed this Jan 11, 2025
@mathlib-bors mathlib-bors bot deleted the split_algebra_group_int branch January 11, 2025 01:21
@mattrobball
Copy link
Copy Markdown
Contributor

Nope it was CI and I had run out of time for the day

Julian added a commit that referenced this pull request Jan 12, 2025
* origin/master: (88 commits)
  chore(scripts): update nolints.json (#20672)
  chore: de-simp `map_eq_zero_iff_eq_one` (#20662)
  feat(Combinatorics/SimpleGraph): add independent sets (#18608)
  chore(CategoryTheory/Limits/Cones): functoriality of `mapCone` (#20641)
  feat(Algebra/Category/ModuleCat): pullback of presheaves of modules (#17366)
  feat(AlgebraicTopology): model categories (#19158)
  chore(CategoryTheory): make NormalEpi/MonoCategory and RegularEpi/MonoCategory props (#19548)
  feat(Data/List/ReduceOption): add replicate theorems (#20644)
  feat: approximate subgroups (#20050)
  feat: use scoped trace nodes in linarith (#19855)
  feat: disjoint union of charted spaces (#20619)
  feat: add some term elaborators for reduction (#15192)
  feat(Topology/Category): category of delta-generated spaces (#19499)
  add a variable_alias for Quantale and AddQuantale (#19282)
  feat(Computability/DFA): implement `isRegular_iff` (#19940)
  chore: unpin and bump batteries and importgraph (#20651)
  chore: split `Mathlib/Algebra/Group/Int` (#20624)
  feat: three lemmas related to Hausdorff distance (#20585)
  chore: `initialize_simps_projections` for `Submodule` (#20582)
  feat(Order): Boolean algebra structure on idempotents (#20618)
  chore(CategoryTheory): moving/renaming Subpresheaf (#20583)
  refactor(IntermediateField/Adjoin): Split off relation to `Algebra.adjoin` (#20630)
  feat: sets of doubling strictly less than 3/2 (#20572)
  chore(TensorProduct): universe polymorphism in EquationalCriterion (#20452)
  feat: `s \ t ∩ u = (s ∩ u) \ t` (#20298)
  feat: product of subalgebras (#20202)
  feat: `Submodule.restrictScalars` commutes with `pow` (#20581)
  feat: `a ∈ s ^ n` iff there exists a sequence `f` of `n` elements of `s` such that `∏ i, f i = a` (#20580)
  chore: make `FooHom.coe_id` a `norm_cast` lemma (#20576)
  chore: use ofNat more (#20546)
  feat(CategoryTheory/Shift/Opposite and CategoryTheory/Shift/Pullback): `CommShift` structures on adjunctions are compatible with opposites and pullbacks (#20363)
  feat(FieldTheory/Differential/Liouville): prove the algebraic case of Liouville's theorem (#16797)
  refactor: remove the `CompactSpace` field from `Unique{NonUnital}ContinuousFunctionalCalculus` (#20590)
  feat: Make `PNat.recOn` induction eliminator (#20617)
  feat(Analysis/SpecialFunctions/Pow/Real): add some lemmas (#20608)
  feat: If `s ∆ t` is finite, then `s ∆ u` is finite iff `t ∆ u` is (#20574)
  feat: `⨅ i, f i ≤ ⨆ i, f i` (#20573)
  chore(Geometry/Manifold): move SmoothManifoldWithCorners.lean to IsManifold.lean (#20611)
  feat: AbsoluteValue.IsNontrivial (#20588)
  chore(Data/Finsupp): split off extensionality from `Defs.lean` (#19092)
  chore(Data/Set): split the `CoeSort` instance to its own file (#19031)
  feat(Algebra/Order/Archimedean/Basic): powers between two elements (#20612)
  feature(Algebra/Ring/Idempotents): product of an idempotent and its complement (#20286)
  chore: cleanup more `erw` (#20601)
  chore(GroupTheory/CoprodI): shorten proof of lift_word_prod_nontrivial_of_not_empty (#20587)
  chore: cleanup imports in PrimePow/Divisors (#20626)
  chore: split Algebra/BigOperators/Group/List (#20625)
  chore: reduce Topology->Order imports by moving content (#20627)
  chore(Algebra/Lie/DirectSum): shorten proof of lieAlgebraOf.map_lie' (#20592)
  refactor: Split `FieldTheory/Adjoin.lean` into `Defs.lean` and `Basic.lean` (#20333)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants