Skip to content

[Merged by Bors] - chore(CategoryTheory): make NormalEpi/MonoCategory and RegularEpi/MonoCategory props#19548

Closed
joelriou wants to merge 3 commits intomasterfrom
normal-mono-category-prop
Closed

[Merged by Bors] - chore(CategoryTheory): make NormalEpi/MonoCategory and RegularEpi/MonoCategory props#19548
joelriou wants to merge 3 commits intomasterfrom
normal-mono-category-prop

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Nov 27, 2024 •
edited
Loading

The names are now prefixed with Is. As a result, the definition of an abelian category Abelian only involve props in addition to the Preadditive instance. With this design, we may avoid diamonds for Abelian instance in some future works (e.g. the abelian category structure on the heart of a t-structure).

Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Nov 27, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 27, 2024 •
edited
Loading

PR summary ab750a4038

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsNormalEpiCategory
+ IsNormalMonoCategory
+ IsRegularEpiCategory
+ IsRegularMonoCategory
+ instance (priority := 100) regularEpiCategoryOfNormalEpiCategory [IsNormalEpiCategory C] :
+ instance (priority := 100) regularMonoCategoryOfNormalMonoCategory [IsNormalMonoCategory C] :
+ instance (priority := 100) strongEpiCategory_of_regularEpiCategory [IsRegularEpiCategory C] :
+ instance (priority := 100) strongMonoCategory_of_regularMonoCategory [IsRegularMonoCategory C] :
+ instance : IsNormalEpiCategory (HomologicalComplex C c) := ⟨fun p _ =>
+ instance : IsNormalEpiCategory (PresheafOfModules.{v} R)
+ instance : IsNormalMonoCategory (HomologicalComplex C c) := ⟨fun p _ =>
+ instance : IsNormalMonoCategory (PresheafOfModules.{v} R)
+ isNormalEpiCategory
+ isNormalMonoCategory
- instance (priority := 100) regularEpiCategoryOfNormalEpiCategory [NormalEpiCategory C] :
- instance (priority := 100) regularMonoCategoryOfNormalMonoCategory [NormalMonoCategory C] :
- instance (priority := 100) strongEpiCategory_of_regularEpiCategory [RegularEpiCategory C] :
- instance (priority := 100) strongMonoCategory_of_regularMonoCategory [RegularMonoCategory C] :
- instance : NormalEpiCategory (HomologicalComplex C c) := ⟨fun p _ =>
- instance : NormalEpiCategory (PresheafOfModules.{v} R)
- instance : NormalMonoCategory (HomologicalComplex C c) := ⟨fun p _ =>
- instance : NormalMonoCategory (PresheafOfModules.{v} R)
- normalEpiCategory
- normalMonoCategory

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

TwoFX
TwoFX approved these changes Jan 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!
bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 11, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 11, 2025
@joelriou
chore(CategoryTheory): make NormalEpi/MonoCategory and RegularEpi/Mon…
cdcfe3a 
…oCategory props (#19548)

The names are now prefixed with `Is`. As a result, the definition of an abelian category `Abelian` only involve props in addition to the `Preadditive` instance. With this design, we may avoid diamonds for `Abelian` instance in some future works (e.g. the abelian category structure on the heart of a t-structure).
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 11, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(CategoryTheory): make NormalEpi/MonoCategory and RegularEpi/MonoCategory props [Merged by Bors] - chore(CategoryTheory): make NormalEpi/MonoCategory and RegularEpi/MonoCategory props Jan 11, 2025
@mathlib-bors mathlib-bors bot closed this Jan 11, 2025
@mathlib-bors mathlib-bors bot deleted the normal-mono-category-prop branch January 11, 2025 13:40
Julian added a commit that referenced this pull request Jan 12, 2025
@Julian
Merge remote-tracking branch 'origin/master' into bhargava-factorial
9ba6079 
* origin/master: (88 commits)
  chore(scripts): update nolints.json (#20672)
  chore: de-simp `map_eq_zero_iff_eq_one` (#20662)
  feat(Combinatorics/SimpleGraph): add independent sets (#18608)
  chore(CategoryTheory/Limits/Cones): functoriality of `mapCone` (#20641)
  feat(Algebra/Category/ModuleCat): pullback of presheaves of modules (#17366)
  feat(AlgebraicTopology): model categories (#19158)
  chore(CategoryTheory): make NormalEpi/MonoCategory and RegularEpi/MonoCategory props (#19548)
  feat(Data/List/ReduceOption): add replicate theorems (#20644)
  feat: approximate subgroups (#20050)
  feat: use scoped trace nodes in linarith (#19855)
  feat: disjoint union of charted spaces (#20619)
  feat: add some term elaborators for reduction (#15192)
  feat(Topology/Category): category of delta-generated spaces (#19499)
  add a variable_alias for Quantale and AddQuantale (#19282)
  feat(Computability/DFA): implement `isRegular_iff` (#19940)
  chore: unpin and bump batteries and importgraph (#20651)
  chore: split `Mathlib/Algebra/Group/Int` (#20624)
  feat: three lemmas related to Hausdorff distance (#20585)
  chore: `initialize_simps_projections` for `Submodule` (#20582)
  feat(Order): Boolean algebra structure on idempotents (#20618)
  chore(CategoryTheory): moving/renaming Subpresheaf (#20583)
  refactor(IntermediateField/Adjoin): Split off relation to `Algebra.adjoin` (#20630)
  feat: sets of doubling strictly less than 3/2 (#20572)
  chore(TensorProduct): universe polymorphism in EquationalCriterion (#20452)
  feat: `s \ t ∩ u = (s ∩ u) \ t` (#20298)
  feat: product of subalgebras (#20202)
  feat: `Submodule.restrictScalars` commutes with `pow` (#20581)
  feat: `a ∈ s ^ n` iff there exists a sequence `f` of `n` elements of `s` such that `∏ i, f i = a` (#20580)
  chore: make `FooHom.coe_id` a `norm_cast` lemma (#20576)
  chore: use ofNat more (#20546)
  feat(CategoryTheory/Shift/Opposite and CategoryTheory/Shift/Pullback): `CommShift` structures on adjunctions are compatible with opposites and pullbacks (#20363)
  feat(FieldTheory/Differential/Liouville): prove the algebraic case of Liouville's theorem (#16797)
  refactor: remove the `CompactSpace` field from `Unique{NonUnital}ContinuousFunctionalCalculus` (#20590)
  feat: Make `PNat.recOn` induction eliminator (#20617)
  feat(Analysis/SpecialFunctions/Pow/Real): add some lemmas (#20608)
  feat: If `s ∆ t` is finite, then `s ∆ u` is finite iff `t ∆ u` is (#20574)
  feat: `⨅ i, f i ≤ ⨆ i, f i` (#20573)
  chore(Geometry/Manifold): move SmoothManifoldWithCorners.lean to IsManifold.lean (#20611)
  feat: AbsoluteValue.IsNontrivial (#20588)
  chore(Data/Finsupp): split off extensionality from `Defs.lean` (#19092)
  chore(Data/Set): split the `CoeSort` instance to its own file (#19031)
  feat(Algebra/Order/Archimedean/Basic): powers between two elements (#20612)
  feature(Algebra/Ring/Idempotents): product of an idempotent and its complement (#20286)
  chore: cleanup more `erw` (#20601)
  chore(GroupTheory/CoprodI): shorten proof of lift_word_prod_nontrivial_of_not_empty (#20587)
  chore: cleanup imports in PrimePow/Divisors (#20626)
  chore: split Algebra/BigOperators/Group/List (#20625)
  chore: reduce Topology->Order imports by moving content (#20627)
  chore(Algebra/Lie/DirectSum): shorten proof of lieAlgebraOf.map_lie' (#20592)
  refactor: Split `FieldTheory/Adjoin.lean` into `Defs.lean` and `Basic.lean` (#20333)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TwoFX TwoFX TwoFX approved these changes

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joelriou @TwoFX