[Merged by Bors] - chore(TensorProduct): universe polymorphism in EquationalCriterion#20452
Closed
alreadydone wants to merge 6 commits intomasterfrom
Closed
[Merged by Bors] - chore(TensorProduct): universe polymorphism in EquationalCriterion#20452alreadydone wants to merge 6 commits intomasterfrom
alreadydone wants to merge 6 commits intomasterfrom
Conversation
PR summary a385013ba8
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Module.FinitePresentation | 1134 | 1137 | +3 (+0.26%) |
| Mathlib.RingTheory.Flat.EquationalCriterion | 1573 | 1576 | +3 (+0.19%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.AlgebraicGeometry.PrimeSpectrum.FreeLocus Mathlib.RingTheory.Localization.Free |
2 |
6 filesMathlib.RingTheory.Smooth.Local Mathlib.Algebra.Module.FinitePresentation Mathlib.Algebra.Module.Presentation.Finite Mathlib.RingTheory.Flat.EquationalCriterion Mathlib.RingTheory.LocalRing.Module Mathlib.RingTheory.LocalProperties.Projective |
3 |
Declarations diff
+ Module.FinitePresentation.exists_fin
+ VanishesTrivially.of_fintype
+ _root_.Equiv.isTrivialRelation_comp
+ _root_.Equiv.vanishesTrivially_comp
+ forall_vanishesTrivially_iff_forall_fg_rTensor_injective
+ projective_of_finitePresentation
+ rTensor_injective_of_forall_fg_rTensor_injective
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
1 task
trivial1711
suggested changes
Jan 4, 2025
Collaborator
There was a problem hiding this comment.
Hi, thanks so much for doing this. I only have a few comments.
- I think you should add your name to the authors list of
Mathlib/LinearAlgebra/TensorProduct/Vanishing.leanandMathlib/RingTheory/Flat/EquationalCriterion.lean. - The docstring of
tfae_equational_criterionstill has the condition that you removed. - Several of the docstrings in
Mathlib/RingTheory/Flat/EquationalCriterion.leanstill refer to$$R^{\kappa}$$ or$$R^{\iota}$$ ; these should be replaced with$$R^k$$ and$$R^\ell$$ respectively.
Also, I didn't realize there was a stacks attribute. Do you think it should be added to the theorems in Mathlib/RingTheory/Flat/EquationalCriterion.lean whose docstrings mention the Stacks project?
Contributor
Author
Contributor
Author
|
By the way, I noticed you use "(module) homomorphism" for what's usually called (including in mathlib) linear maps in the file EquationalCriterion; if you'd like to open a PR to change the terminology I'd quickly approve. |
trivial1711
approved these changes
Jan 5, 2025
Collaborator
trivial1711
left a comment
There was a problem hiding this comment.
Can you get rid of the TODO in Mathlib/Algebra/Module/FinitePresentation.lean that refers to universe polymorphism? Otherwise, this is looking great; thanks so much for cleaning up the mess that I made.
Contributor
Author
|
Where is the TODO? |
Collaborator
|
I mean Mathlib/LinearAlgebra/TensorProduct/Vanishing.lean; sorry. |
alreadydone
commented
Jan 5, 2025
Member
|
Thanks! |
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
We change all occurrences of "module homomorphism" in docstrings to "linear map". See here: #20452 (comment) Co-authored-by: Mitchell Lee <130885647+trivial1711@users.noreply.github.com>
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
We change all occurrences of "module homomorphism" in docstrings to "linear map". See here: #20452 (comment) Co-authored-by: Mitchell Lee <130885647+trivial1711@users.noreply.github.com>
alreadydone
commented
Jan 10, 2025
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
…20452) Remove `exists_factorization_of_apply_eq_zero` as it's a special case of `exists_factorization_of_apply_eq_zero_of_free`. Remove one statement from the TFAE, but still keep the forward direction ` `exists_factorization_of_apply_eq_zero_of_free` and make it fully universe polymorphic.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
grunweg
pushed a commit
that referenced
this pull request
Jan 11, 2025
…20452) Remove `exists_factorization_of_apply_eq_zero` as it's a special case of `exists_factorization_of_apply_eq_zero_of_free`. Remove one statement from the TFAE, but still keep the forward direction ` `exists_factorization_of_apply_eq_zero_of_free` and make it fully universe polymorphic.
Julian
added a commit
that referenced
this pull request
Jan 12, 2025
* origin/master: (88 commits) chore(scripts): update nolints.json (#20672) chore: de-simp `map_eq_zero_iff_eq_one` (#20662) feat(Combinatorics/SimpleGraph): add independent sets (#18608) chore(CategoryTheory/Limits/Cones): functoriality of `mapCone` (#20641) feat(Algebra/Category/ModuleCat): pullback of presheaves of modules (#17366) feat(AlgebraicTopology): model categories (#19158) chore(CategoryTheory): make NormalEpi/MonoCategory and RegularEpi/MonoCategory props (#19548) feat(Data/List/ReduceOption): add replicate theorems (#20644) feat: approximate subgroups (#20050) feat: use scoped trace nodes in linarith (#19855) feat: disjoint union of charted spaces (#20619) feat: add some term elaborators for reduction (#15192) feat(Topology/Category): category of delta-generated spaces (#19499) add a variable_alias for Quantale and AddQuantale (#19282) feat(Computability/DFA): implement `isRegular_iff` (#19940) chore: unpin and bump batteries and importgraph (#20651) chore: split `Mathlib/Algebra/Group/Int` (#20624) feat: three lemmas related to Hausdorff distance (#20585) chore: `initialize_simps_projections` for `Submodule` (#20582) feat(Order): Boolean algebra structure on idempotents (#20618) chore(CategoryTheory): moving/renaming Subpresheaf (#20583) refactor(IntermediateField/Adjoin): Split off relation to `Algebra.adjoin` (#20630) feat: sets of doubling strictly less than 3/2 (#20572) chore(TensorProduct): universe polymorphism in EquationalCriterion (#20452) feat: `s \ t ∩ u = (s ∩ u) \ t` (#20298) feat: product of subalgebras (#20202) feat: `Submodule.restrictScalars` commutes with `pow` (#20581) feat: `a ∈ s ^ n` iff there exists a sequence `f` of `n` elements of `s` such that `∏ i, f i = a` (#20580) chore: make `FooHom.coe_id` a `norm_cast` lemma (#20576) chore: use ofNat more (#20546) feat(CategoryTheory/Shift/Opposite and CategoryTheory/Shift/Pullback): `CommShift` structures on adjunctions are compatible with opposites and pullbacks (#20363) feat(FieldTheory/Differential/Liouville): prove the algebraic case of Liouville's theorem (#16797) refactor: remove the `CompactSpace` field from `Unique{NonUnital}ContinuousFunctionalCalculus` (#20590) feat: Make `PNat.recOn` induction eliminator (#20617) feat(Analysis/SpecialFunctions/Pow/Real): add some lemmas (#20608) feat: If `s ∆ t` is finite, then `s ∆ u` is finite iff `t ∆ u` is (#20574) feat: `⨅ i, f i ≤ ⨆ i, f i` (#20573) chore(Geometry/Manifold): move SmoothManifoldWithCorners.lean to IsManifold.lean (#20611) feat: AbsoluteValue.IsNontrivial (#20588) chore(Data/Finsupp): split off extensionality from `Defs.lean` (#19092) chore(Data/Set): split the `CoeSort` instance to its own file (#19031) feat(Algebra/Order/Archimedean/Basic): powers between two elements (#20612) feature(Algebra/Ring/Idempotents): product of an idempotent and its complement (#20286) chore: cleanup more `erw` (#20601) chore(GroupTheory/CoprodI): shorten proof of lift_word_prod_nontrivial_of_not_empty (#20587) chore: cleanup imports in PrimePow/Divisors (#20626) chore: split Algebra/BigOperators/Group/List (#20625) chore: reduce Topology->Order imports by moving content (#20627) chore(Algebra/Lie/DirectSum): shorten proof of lieAlgebraOf.map_lie' (#20592) refactor: Split `FieldTheory/Adjoin.lean` into `Defs.lean` and `Basic.lean` (#20333) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
exists_factorization_of_apply_eq_zeroas it's a special case ofexists_factorization_of_apply_eq_zero_of_free.Remove one statement from the TFAE, but still keep the forward direction