[Merged by Bors] - chore(Algebra/Lie): make IsNilpotent and IsSolvable independent of scalars by jcommelin · Pull Request #20556 · leanprover-community/mathlib4

jcommelin · 2025-01-07T16:36:22Z

github-actions · 2025-01-07T16:37:14Z

PR summary 6fdcbd8f1e

Import changes for modified files

No significant changes to the import graph

Import changes for all files

Files	Import difference

Declarations diff

+ IsNilpotent.mk
+ IsNilpotent.nilpotent
+ IsSolvable.mk
+ IsSolvable.solvable
+ LieRing.IsNilpotent
+ coe_derivedSeries_eq_int
+ coe_lowerCentralSeries_eq_int
+ instance (A : LieIdeal R L) [IsSolvable L] : IsSolvable A
+ instance (priority := 100) LieAlgebra.isSolvable_of_isNilpotent (L : Type v)
+ instance (priority := 100) ofAbelianIsSolvable [IsLieAbelian L] : IsSolvable L := by
+ instance (priority := 100) trivialIsNilpotent [IsTrivial L M] : IsNilpotent L M
+ instance : LieModule ℤ L M
+ instance [H.IsCartanSubalgebra] : LieRing.IsNilpotent H
+ instance [IsNoetherian R M] : IsNilpotent L (shiftedGenWeightSpace R L M χ)
+ instance [IsSolvable L] : IsSolvable (⊤ : LieSubalgebra R L) := by
+ instance [h : LieRing.IsNilpotent L] : LieRing.IsNilpotent (⊤ : LieSubalgebra R L)
+ isSolvable_iff
- LieAlgebra.IsNilpotent
- instance (A : LieIdeal R L) [IsSolvable R L] : IsSolvable R A
- instance (priority := 100) LieAlgebra.isSolvable_of_isNilpotent (R : Type u) (L : Type v)
- instance (priority := 100) ofAbelianIsSolvable [IsLieAbelian L] : IsSolvable R L := by
- instance (priority := 100) trivialIsNilpotent [IsTrivial L M] : IsNilpotent R L M
- instance [H.IsCartanSubalgebra] : LieAlgebra.IsNilpotent R H
- instance [IsNoetherian R M] : IsNilpotent R L (shiftedGenWeightSpace R L M χ)
- instance [IsSolvable R L] : IsSolvable R (⊤ : LieSubalgebra R L) := by
- instance [h : LieAlgebra.IsNilpotent R L] : LieAlgebra.IsNilpotent R (⊤ : LieSubalgebra R L)

You can run this locally as follows

## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary

The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

ocfnash

Just three suggestions (which I'm quite keen on) but otherwise LGTM.

Thanks for doing this!

bors d+

Mathlib/Algebra/Lie/Nilpotent.lean

Mathlib/Algebra/Lie/Solvable.lean

mathlib-bors · 2025-01-07T21:39:40Z

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

jcommelin · 2025-01-08T05:26:54Z

bors r+

…alars (#20556)

mathlib-bors · 2025-01-08T05:38:59Z

Pull request successfully merged into master.

Build succeeded:

* origin/master: (642 commits) feat: the Boolean subalgebra generated by the lattice generated by a set (#20440) feat: misc. lemmas about moments, tilted measures (#20150) chore(Algebra/Lie): make IsNilpotent and IsSolvable independent of scalars (#20556) feat(Combinatorics/SimpleGraph/Path): add `IsPath.getVert_injOn` (#19373) feat(Combinatorics/SimpleGraph): add lemmas about `spanningCoe` (#19377) chore: scope 'on' notation to Function (#20562) chore: disable docPrime linter (#20559) chore: deprecate MulRingNorm._ in favour of AbsoluteValue._ (#20557) fix(scripts/bench_summary): input jobID as a Nat, rather than a String (#20539) chore: move results about `DivisionMonoid` + `HasDistribNeg` (#20551) feat(NumberTheory/NumberField/Embeddings): definition of totally real field (#20542) chore(Noetherian/Artinian): generalize to Semiring (#20534) chore: protect `Filter.nhds_{iInf,inf}` (#20530) chore(AlgebraicTopology): move SplitSimplicialObject.lean (#20511) chore: extract 3 new files out of MeasureSpace (#20509) feat(RingTheory): Jacobian criterion for smoothness of local algebras (#20326) doc(RingTheory/Flat): add reference to Lambek's paper (#20266) feat(NumberTheory/AbelSummation): add more results (#19942) chore(Multilinear/Basic): generalize the `SMul` instance (#20536) feat(FDeriv/Equiv): generalize `HasFDerivAt.of_local_left_inverse` (#20516) feat(ContDiff): add `iteratedFDeriv_comp` (#20472) feat(LowerUpperTopology): add lemmas (#20465) feat(ContDiff): weaken some assumptions (#20368) fix(scripts/technical-debt-metric): avoid division by 0 (#20537) chore(Algebra/Ring): Clean up in SumsOfSquares and Semireal/Defs (#20528) feat(FTaylorSeries): add lemmas about `dist` between 0th and 1st derivs (#20089) feat: results on inner regularity of finite measures (#19780) chore: to_additive various results on groups, group actions (#20547) feat(Probability/Kernel): `Kernel.sectL` and `sectR` (#15466) chore(CategoryTheory/Limits/Fubini): relax universes constraints and weaken hypotheses (#20553) perf: remove `@[simp]` on `Fintype.card_of{IsEmpty,Subsingleton}` (#20524) fix(HashCommandLinter): remove unnecessary, broken workaround for tests (#20529) chore(Ideal/Basic): dependent generalization of `Ideal.pi` (#20535) feat(RingTheory): being unramified is a local property (#20323) chore(BooleanSubalgebra): use `IsSublattice` in `closure_sdiff_sup_induction` (#20439) feat(Order/SuccPred/CompleteLinearOrder): `⨆ a < x, succ a = x` (#19970) chore(*): replace `no_index (ofNat n)` with `ofNat(n)` everywhere (#20521) feat(CategoryTheory/Triangulated/Adjunction): the right adjoint of a triangulated functor is triangulated (#20255) chore(Order/SuccPred/LinearLocallyFinite): change data-creating instances to defs (#20235) chore: don't import algebra in `Data.Finset.Basic` (#19779) feat: initial segment commutes with `Iio` (#20503) chore(Measure/Pi): move parts to `MeasurableSpace/` (#20215) chore: smile more often (#20436) chore(Algebra/Category/MonCat/ForgetCorepresentable, Algebra/Group/Equiv/Basic): move definitions and add symmetric version (#20416) feat(GroupTheory/QuotientGroup): group correspondence theorem (#20007) doc: change "module homomorphism" to "linear map" (#20481) perf: improves the performance of the `Repr (Equiv.Perm α)` instance (1/4) (#20519) fix: do not keep only the first line of hints (#19756) feat(Analysis/Analytic): lemmas about `smul` for power series (#19816) chore: don't import algebra in `Data.Multiset.Basic` (#19775) ...

* origin/master: (80 commits) chore(CategoryTheory): remove data produced by tactic block (#20565) feat: `|∫ a, f a ∂μ| ≤ ∫ a, |f a| ∂μ` (#20540) feat: the Boolean subalgebra generated by the lattice generated by a set (#20440) feat: misc. lemmas about moments, tilted measures (#20150) chore(Algebra/Lie): make IsNilpotent and IsSolvable independent of scalars (#20556) feat(Combinatorics/SimpleGraph/Path): add `IsPath.getVert_injOn` (#19373) feat(Combinatorics/SimpleGraph): add lemmas about `spanningCoe` (#19377) chore: scope 'on' notation to Function (#20562) chore: disable docPrime linter (#20559) chore: deprecate MulRingNorm._ in favour of AbsoluteValue._ (#20557) fix(scripts/bench_summary): input jobID as a Nat, rather than a String (#20539) chore: move results about `DivisionMonoid` + `HasDistribNeg` (#20551) feat(NumberTheory/NumberField/Embeddings): definition of totally real field (#20542) chore(Noetherian/Artinian): generalize to Semiring (#20534) chore: protect `Filter.nhds_{iInf,inf}` (#20530) chore(AlgebraicTopology): move SplitSimplicialObject.lean (#20511) chore: extract 3 new files out of MeasureSpace (#20509) feat(RingTheory): Jacobian criterion for smoothness of local algebras (#20326) doc(RingTheory/Flat): add reference to Lambek's paper (#20266) feat(NumberTheory/AbelSummation): add more results (#19942) chore(Multilinear/Basic): generalize the `SMul` instance (#20536) feat(FDeriv/Equiv): generalize `HasFDerivAt.of_local_left_inverse` (#20516) feat(ContDiff): add `iteratedFDeriv_comp` (#20472) feat(LowerUpperTopology): add lemmas (#20465) feat(ContDiff): weaken some assumptions (#20368) fix(scripts/technical-debt-metric): avoid division by 0 (#20537) chore(Algebra/Ring): Clean up in SumsOfSquares and Semireal/Defs (#20528) feat(FTaylorSeries): add lemmas about `dist` between 0th and 1st derivs (#20089) feat: results on inner regularity of finite measures (#19780) chore: to_additive various results on groups, group actions (#20547) feat(Probability/Kernel): `Kernel.sectL` and `sectR` (#15466) chore(CategoryTheory/Limits/Fubini): relax universes constraints and weaken hypotheses (#20553) perf: remove `@[simp]` on `Fintype.card_of{IsEmpty,Subsingleton}` (#20524) fix(HashCommandLinter): remove unnecessary, broken workaround for tests (#20529) chore(Ideal/Basic): dependent generalization of `Ideal.pi` (#20535) feat(RingTheory): being unramified is a local property (#20323) chore(BooleanSubalgebra): use `IsSublattice` in `closure_sdiff_sup_induction` (#20439) feat(Order/SuccPred/CompleteLinearOrder): `⨆ a < x, succ a = x` (#19970) chore(*): replace `no_index (ofNat n)` with `ofNat(n)` everywhere (#20521) feat(CategoryTheory/Triangulated/Adjunction): the right adjoint of a triangulated functor is triangulated (#20255) chore(Order/SuccPred/LinearLocallyFinite): change data-creating instances to defs (#20235) chore: don't import algebra in `Data.Finset.Basic` (#19779) feat: initial segment commutes with `Iio` (#20503) chore(Measure/Pi): move parts to `MeasurableSpace/` (#20215) chore: smile more often (#20436) chore(Algebra/Category/MonCat/ForgetCorepresentable, Algebra/Group/Equiv/Basic): move definitions and add symmetric version (#20416) feat(GroupTheory/QuotientGroup): group correspondence theorem (#20007) doc: change "module homomorphism" to "linear map" (#20481) perf: improves the performance of the `Repr (Equiv.Perm α)` instance (1/4) (#20519) fix: do not keep only the first line of hints (#19756) ...

jcommelin added 3 commits January 6, 2025 17:28

wip

65c5899

wip

9a7e09e

wip

e25f142

github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Jan 7, 2025

move

51ba897

jcommelin marked this pull request as ready for review January 7, 2025 16:39

lint

263cf27

ocfnash approved these changes Jan 7, 2025

View reviewed changes

Mathlib/Algebra/Lie/Nilpotent.lean Outdated Show resolved Hide resolved

Mathlib/Algebra/Lie/Nilpotent.lean Outdated Show resolved Hide resolved

Mathlib/Algebra/Lie/Solvable.lean Outdated Show resolved Hide resolved

ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 7, 2025

process review comments

6fdcbd8

ghost added the ready-to-merge This PR has been sent to bors. label Jan 8, 2025

mathlib-bors bot pushed a commit that referenced this pull request Jan 8, 2025

chore(Algebra/Lie): make IsNilpotent and IsSolvable independent of sc…

4c75337

…alars (#20556)

mathlib-bors bot changed the title ~~chore(Algebra/Lie): make IsNilpotent and IsSolvable independent of scalars~~ [Merged by Bors] - chore(Algebra/Lie): make IsNilpotent and IsSolvable independent of scalars Jan 8, 2025

mathlib-bors bot closed this Jan 8, 2025

mathlib-bors bot deleted the jmc-lie-solvable-scalars branch January 8, 2025 05:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - chore(Algebra/Lie): make IsNilpotent and IsSolvable independent of scalars#20556

[Merged by Bors] - chore(Algebra/Lie): make IsNilpotent and IsSolvable independent of scalars#20556
jcommelin wants to merge 6 commits intomasterfrom
jmc-lie-solvable-scalars

jcommelin commented Jan 7, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 7, 2025 •

edited

Loading

Declarations diff

Uh oh!

ocfnash left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mathlib-bors bot commented Jan 7, 2025

Uh oh!

jcommelin commented Jan 8, 2025

Uh oh!

mathlib-bors bot commented Jan 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jcommelin commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR summary 6fdcbd8f1e

Import changes for modified files

Declarations diff

Uh oh!

ocfnash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mathlib-bors bot commented Jan 7, 2025

Uh oh!

jcommelin commented Jan 8, 2025

Uh oh!

mathlib-bors bot commented Jan 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jcommelin commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading