[Merged by Bors] - fix: do not keep only the first line of hints by eric-wieser · Pull Request #19756 · leanprover-community/mathlib4

eric-wieser · 2024-12-05T22:45:09Z

This is still not really the right approach, but it's clearly less wrong.

github-actions · 2024-12-05T22:46:02Z

PR summary 83558bf6b7

Import changes for modified files

No significant changes to the import graph

Import changes for all files

Files	Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows

## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary

The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

adomani · 2024-12-05T23:35:58Z

It looks reasonable to me. Should there be a test? Possibly one that involves trying a suggestion that would replace code followed by a comment, to make sure that the comment does not get mangled?

kim-em · 2024-12-05T23:44:07Z

Clear improvement! :-) Happy if you want to add a test, or not.

bors d+

mathlib-bors · 2024-12-05T23:44:09Z

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

adomani · 2024-12-06T07:41:00Z

Mathlib/Tactic/Hint.lean

    m.severity == MessageSeverity.information && (← m.data.toString).startsWith "Try this: "
  let suggestion ← match msg? with
-  | some m => pure <| SuggestionText.string (((← m.data.toString).drop 10).takeWhile (· != '\n'))
+  | some m => pure <| SuggestionText.string ((← m.data.toString).drop 10)


Suggested change

| some m => pure <| SuggestionText.string ((← m.data.toString).drop 10)

| some m => pure <| SuggestionText.string (((← m.data.toString).drop 10).dropWhile (· == '\n'))

Trying out an example, I think that it was drop, rather than take!

Maybe even trimLeft would be good.

Do you have an example in mind where this has any effect?

I think that if you use the version in this PR you get

/-- info: Try these: • ⏎ trivial --- warning: declaration uses 'sorry' -/ #guard_msgs in example : 37 = 37 := by hint

while with the dropWhile you get

/-- info: Try these: • trivial --- warning: declaration uses 'sorry' -/ #guard_msgs in example : 37 = 37 := by hint

I only see the second version with the PR in its current state, with

import Mathlib.Tactic.Hint -- newline to cause trouble, just in case! register_hint trivial /-- info: Try these: • trivial -/ #guard_msgs in example : 37 = 37 := by hint

If newline really are ending up in the tactics, then i think it's the job of the register_hint'd tactic to not emit the newline in the first palce, not of hint to try to clean up.

When I tried this with the version in master, everything seems to work. I do not know what was happening before, but I am comforted by the fact that I did not dream this by the line-break character that #guard_msgs introduces automatically and that I certainly did not type myself!

eric-wieser · 2025-01-07T01:14:25Z

bors merge

This is still not really the right approach, but it's clearly less wrong.

mathlib-bors · 2025-01-07T02:04:12Z

Pull request successfully merged into master.

Build succeeded:

* origin/master: (642 commits) feat: the Boolean subalgebra generated by the lattice generated by a set (#20440) feat: misc. lemmas about moments, tilted measures (#20150) chore(Algebra/Lie): make IsNilpotent and IsSolvable independent of scalars (#20556) feat(Combinatorics/SimpleGraph/Path): add `IsPath.getVert_injOn` (#19373) feat(Combinatorics/SimpleGraph): add lemmas about `spanningCoe` (#19377) chore: scope 'on' notation to Function (#20562) chore: disable docPrime linter (#20559) chore: deprecate MulRingNorm._ in favour of AbsoluteValue._ (#20557) fix(scripts/bench_summary): input jobID as a Nat, rather than a String (#20539) chore: move results about `DivisionMonoid` + `HasDistribNeg` (#20551) feat(NumberTheory/NumberField/Embeddings): definition of totally real field (#20542) chore(Noetherian/Artinian): generalize to Semiring (#20534) chore: protect `Filter.nhds_{iInf,inf}` (#20530) chore(AlgebraicTopology): move SplitSimplicialObject.lean (#20511) chore: extract 3 new files out of MeasureSpace (#20509) feat(RingTheory): Jacobian criterion for smoothness of local algebras (#20326) doc(RingTheory/Flat): add reference to Lambek's paper (#20266) feat(NumberTheory/AbelSummation): add more results (#19942) chore(Multilinear/Basic): generalize the `SMul` instance (#20536) feat(FDeriv/Equiv): generalize `HasFDerivAt.of_local_left_inverse` (#20516) feat(ContDiff): add `iteratedFDeriv_comp` (#20472) feat(LowerUpperTopology): add lemmas (#20465) feat(ContDiff): weaken some assumptions (#20368) fix(scripts/technical-debt-metric): avoid division by 0 (#20537) chore(Algebra/Ring): Clean up in SumsOfSquares and Semireal/Defs (#20528) feat(FTaylorSeries): add lemmas about `dist` between 0th and 1st derivs (#20089) feat: results on inner regularity of finite measures (#19780) chore: to_additive various results on groups, group actions (#20547) feat(Probability/Kernel): `Kernel.sectL` and `sectR` (#15466) chore(CategoryTheory/Limits/Fubini): relax universes constraints and weaken hypotheses (#20553) perf: remove `@[simp]` on `Fintype.card_of{IsEmpty,Subsingleton}` (#20524) fix(HashCommandLinter): remove unnecessary, broken workaround for tests (#20529) chore(Ideal/Basic): dependent generalization of `Ideal.pi` (#20535) feat(RingTheory): being unramified is a local property (#20323) chore(BooleanSubalgebra): use `IsSublattice` in `closure_sdiff_sup_induction` (#20439) feat(Order/SuccPred/CompleteLinearOrder): `⨆ a < x, succ a = x` (#19970) chore(*): replace `no_index (ofNat n)` with `ofNat(n)` everywhere (#20521) feat(CategoryTheory/Triangulated/Adjunction): the right adjoint of a triangulated functor is triangulated (#20255) chore(Order/SuccPred/LinearLocallyFinite): change data-creating instances to defs (#20235) chore: don't import algebra in `Data.Finset.Basic` (#19779) feat: initial segment commutes with `Iio` (#20503) chore(Measure/Pi): move parts to `MeasurableSpace/` (#20215) chore: smile more often (#20436) chore(Algebra/Category/MonCat/ForgetCorepresentable, Algebra/Group/Equiv/Basic): move definitions and add symmetric version (#20416) feat(GroupTheory/QuotientGroup): group correspondence theorem (#20007) doc: change "module homomorphism" to "linear map" (#20481) perf: improves the performance of the `Repr (Equiv.Perm α)` instance (1/4) (#20519) fix: do not keep only the first line of hints (#19756) feat(Analysis/Analytic): lemmas about `smul` for power series (#19816) chore: don't import algebra in `Data.Multiset.Basic` (#19775) ...

* origin/master: (80 commits) chore(CategoryTheory): remove data produced by tactic block (#20565) feat: `|∫ a, f a ∂μ| ≤ ∫ a, |f a| ∂μ` (#20540) feat: the Boolean subalgebra generated by the lattice generated by a set (#20440) feat: misc. lemmas about moments, tilted measures (#20150) chore(Algebra/Lie): make IsNilpotent and IsSolvable independent of scalars (#20556) feat(Combinatorics/SimpleGraph/Path): add `IsPath.getVert_injOn` (#19373) feat(Combinatorics/SimpleGraph): add lemmas about `spanningCoe` (#19377) chore: scope 'on' notation to Function (#20562) chore: disable docPrime linter (#20559) chore: deprecate MulRingNorm._ in favour of AbsoluteValue._ (#20557) fix(scripts/bench_summary): input jobID as a Nat, rather than a String (#20539) chore: move results about `DivisionMonoid` + `HasDistribNeg` (#20551) feat(NumberTheory/NumberField/Embeddings): definition of totally real field (#20542) chore(Noetherian/Artinian): generalize to Semiring (#20534) chore: protect `Filter.nhds_{iInf,inf}` (#20530) chore(AlgebraicTopology): move SplitSimplicialObject.lean (#20511) chore: extract 3 new files out of MeasureSpace (#20509) feat(RingTheory): Jacobian criterion for smoothness of local algebras (#20326) doc(RingTheory/Flat): add reference to Lambek's paper (#20266) feat(NumberTheory/AbelSummation): add more results (#19942) chore(Multilinear/Basic): generalize the `SMul` instance (#20536) feat(FDeriv/Equiv): generalize `HasFDerivAt.of_local_left_inverse` (#20516) feat(ContDiff): add `iteratedFDeriv_comp` (#20472) feat(LowerUpperTopology): add lemmas (#20465) feat(ContDiff): weaken some assumptions (#20368) fix(scripts/technical-debt-metric): avoid division by 0 (#20537) chore(Algebra/Ring): Clean up in SumsOfSquares and Semireal/Defs (#20528) feat(FTaylorSeries): add lemmas about `dist` between 0th and 1st derivs (#20089) feat: results on inner regularity of finite measures (#19780) chore: to_additive various results on groups, group actions (#20547) feat(Probability/Kernel): `Kernel.sectL` and `sectR` (#15466) chore(CategoryTheory/Limits/Fubini): relax universes constraints and weaken hypotheses (#20553) perf: remove `@[simp]` on `Fintype.card_of{IsEmpty,Subsingleton}` (#20524) fix(HashCommandLinter): remove unnecessary, broken workaround for tests (#20529) chore(Ideal/Basic): dependent generalization of `Ideal.pi` (#20535) feat(RingTheory): being unramified is a local property (#20323) chore(BooleanSubalgebra): use `IsSublattice` in `closure_sdiff_sup_induction` (#20439) feat(Order/SuccPred/CompleteLinearOrder): `⨆ a < x, succ a = x` (#19970) chore(*): replace `no_index (ofNat n)` with `ofNat(n)` everywhere (#20521) feat(CategoryTheory/Triangulated/Adjunction): the right adjoint of a triangulated functor is triangulated (#20255) chore(Order/SuccPred/LinearLocallyFinite): change data-creating instances to defs (#20235) chore: don't import algebra in `Data.Finset.Basic` (#19779) feat: initial segment commutes with `Iio` (#20503) chore(Measure/Pi): move parts to `MeasurableSpace/` (#20215) chore: smile more often (#20436) chore(Algebra/Category/MonCat/ForgetCorepresentable, Algebra/Group/Equiv/Basic): move definitions and add symmetric version (#20416) feat(GroupTheory/QuotientGroup): group correspondence theorem (#20007) doc: change "module homomorphism" to "linear map" (#20481) perf: improves the performance of the `Repr (Equiv.Perm α)` instance (1/4) (#20519) fix: do not keep only the first line of hints (#19756) ...

fix: do not keep only the first line of hints

c9c4d8d

This is still not really the right approach, but it's clearly less wrong.

eric-wieser added the bug Something is not working label Dec 5, 2024

eric-wieser requested a review from kim-em December 5, 2024 22:45

github-actions bot added the t-meta Tactics, attributes or user commands label Dec 5, 2024

ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Dec 5, 2024

adomani reviewed Dec 6, 2024

View reviewed changes

add a test that fails on master

83558bf

ghost added the ready-to-merge This PR has been sent to bors. label Jan 7, 2025

mathlib-bors bot pushed a commit that referenced this pull request Jan 7, 2025

fix: do not keep only the first line of hints (#19756)

9df640d

This is still not really the right approach, but it's clearly less wrong.

mathlib-bors bot changed the title ~~fix: do not keep only the first line of hints~~ [Merged by Bors] - fix: do not keep only the first line of hints Jan 7, 2025

mathlib-bors bot closed this Jan 7, 2025

mathlib-bors bot deleted the eric-wieser/hint-fix branch January 7, 2025 02:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - fix: do not keep only the first line of hints#19756

[Merged by Bors] - fix: do not keep only the first line of hints#19756
eric-wieser wants to merge 2 commits intomasterfrom
eric-wieser/hint-fix

eric-wieser commented Dec 5, 2024

Uh oh!

github-actions bot commented Dec 5, 2024 •

edited

Loading

Uh oh!

adomani commented Dec 5, 2024

Uh oh!

kim-em commented Dec 5, 2024

Uh oh!

mathlib-bors bot commented Dec 5, 2024

Uh oh!

adomani Dec 6, 2024 •

edited

Loading

Uh oh!

eric-wieser Dec 17, 2024

Uh oh!

adomani Jan 6, 2025

Uh oh!

eric-wieser Jan 7, 2025 •

edited

Loading

Uh oh!

adomani Jan 7, 2025

Uh oh!

eric-wieser commented Jan 7, 2025

Uh oh!

mathlib-bors bot commented Jan 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	\| some m => pure <\| SuggestionText.string ((← m.data.toString).drop 10)
	\| some m => pure <\| SuggestionText.string (((← m.data.toString).drop 10).dropWhile (· == '\n'))

Conversation

eric-wieser commented Dec 5, 2024

Uh oh!

github-actions bot commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR summary 83558bf6b7

Import changes for modified files

Declarations diff

Uh oh!

adomani commented Dec 5, 2024

Uh oh!

kim-em commented Dec 5, 2024

Uh oh!

mathlib-bors bot commented Dec 5, 2024

Uh oh!

adomani Dec 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eric-wieser Dec 17, 2024

Choose a reason for hiding this comment

Uh oh!

adomani Jan 6, 2025

Choose a reason for hiding this comment

Uh oh!

eric-wieser Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adomani Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

eric-wieser commented Jan 7, 2025

Uh oh!

mathlib-bors bot commented Jan 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 5, 2024 •

edited

Loading

adomani Dec 6, 2024 •

edited

Loading

eric-wieser Jan 7, 2025 •

edited

Loading