Skip to content

[Merged by Bors] - feat(RingTheory/Flat): flat is a local property of ring homomorphisms#19789

Closed
chrisflav wants to merge 8 commits intomasterfrom
chrisflav-flat-meta
Closed

[Merged by Bors] - feat(RingTheory/Flat): flat is a local property of ring homomorphisms#19789
chrisflav wants to merge 8 commits intomasterfrom
chrisflav-flat-meta

Conversation

@chrisflav
Copy link
Copy Markdown
Member

@chrisflav chrisflav commented Dec 7, 2024 •
edited by alreadydone
Loading

@chrisflav chrisflav added the t-algebra Algebra (groups, rings, fields, etc) label Dec 7, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2024 •
edited
Loading

PR summary 0ca7dad04d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ofLocalizationSpanTarget
+ propertyIsLocal

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Dec 7, 2024
@chrisflav chrisflav mentioned this pull request Dec 8, 2024
Closed
1 task
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 9, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Dec 20, 2024
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

mathlib4-dependent-issues-bot commented Dec 20, 2024

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 21, 2024
joelriou
joelriou reviewed Dec 22, 2024
View reviewed changes
joelriou
joelriou reviewed Dec 22, 2024
View reviewed changes
joelriou
joelriou reviewed Dec 22, 2024
View reviewed changes
alreadydone
alreadydone reviewed Dec 22, 2024
View reviewed changes
@alreadydone
Copy link
Copy Markdown
Contributor

alreadydone commented Dec 22, 2024

maintainer delegate

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 22, 2024

🚀 Pull request has been placed on the maintainer queue by alreadydone.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 22, 2024
@riccardobrasca
Copy link
Copy Markdown
Member

riccardobrasca commented Dec 22, 2024

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 22, 2024

✌️ chrisflav can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Dec 22, 2024
@chrisflav @alreadydone
Update Mathlib/RingTheory/RingHom/Flat.lean
0ca7dad 
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
@chrisflav
Copy link
Copy Markdown
Member Author

chrisflav commented Dec 22, 2024

Thanks for the reviews!

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Dec 22, 2024
@chrisflav
feat(RingTheory/Flat): flat is a local property of ring homomorphisms (…
e975eed 
…#19789)

We show that `RingHom.Flat` satisfies `RingHom.PropertyIsLocal`.



Co-authored-by: Christian Merten <136261474+chrisflav@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 22, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory/Flat): flat is a local property of ring homomorphisms [Merged by Bors] - feat(RingTheory/Flat): flat is a local property of ring homomorphisms Dec 22, 2024
@mathlib-bors mathlib-bors bot closed this Dec 22, 2024
@mathlib-bors mathlib-bors bot deleted the chrisflav-flat-meta branch December 22, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelriou joelriou joelriou left review comments

@alreadydone alreadydone alreadydone approved these changes

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chrisflav @mathlib4-dependent-issues-bot @alreadydone @riccardobrasca @joelriou @leanprover-community-bot-assistant