[Merged by Bors] - chore(RingTheory/Flat): remove Algebra.Flat and move RingHom.Flat#19786
Closed
[Merged by Bors] - chore(RingTheory/Flat): remove Algebra.Flat and move RingHom.Flat#19786
Algebra.Flat and move RingHom.Flat#19786Conversation
PR summary 7d7497726d
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.Flat.Algebra | 1531 | 0 | -1531 (-100.00%) |
| Mathlib.RingTheory.AdicCompletion.AsTensorProduct | 1776 | 1766 | -10 (-0.56%) |
| Mathlib.Algebra.Category.Ring.Under.Limits | 1611 | 1620 | +9 (+0.56%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.RingTheory.Flat.Algebra |
-1531 |
Mathlib.RingTheory.AdicCompletion.AsTensorProduct |
-10 |
Mathlib.Algebra.Category.Ring.Under.Limits |
9 |
Mathlib.RingTheory.RingHom.Flat (new file) |
1598 |
Declarations diff
+ containsIdentities
+ holdsForLocalizationAway
+ id
+ isStableUnderBaseChange
+ of_bijective
+ respectsIso
+ stableUnderComposition
- Algebra.Flat
- baseChange
- identity
- isBaseChange
- self
- trans
--+ comp
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
alreadydone
approved these changes
Dec 7, 2024
Contributor
alreadydone
left a comment
There was a problem hiding this comment.
LGTM!
I'll let the maintainer decide whether to add deprecated aliases for Algebra.Flat(.self/.trans/.baseChange/.isBaseChange).
maintainer delegate
|
🚀 Pull request has been placed on the maintainer queue by alreadydone. |
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Closed
2 tasks
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
…#19786) We remove `Algebra.Flat` as it is a special case of `Module.Flat` and make `RingHom.Flat` a regular definition to align with e.g. `RingHom.Finite`. Also adds some meta properties of flat ring homomorphisms. Co-authored-by: Christian Merten <136261474+chrisflav@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Algebra.Flat and move RingHom.FlatAlgebra.Flat and move RingHom.Flat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We remove
Algebra.Flatas it is a special case ofModule.Flatand makeRingHom.Flata regular definition to align with e.g.RingHom.Finite. Also adds some meta properties of flat ring homomorphisms.