[Merged by Bors] - feat(RingTheory/Flat): generalize flat_of_isLocalized_span#19788
[Merged by Bors] - feat(RingTheory/Flat): generalize flat_of_isLocalized_span#19788
flat_of_isLocalized_span#19788Conversation
PR summary 18347b6548
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.Localization.BaseChange | 988 | 990 | +2 (+0.20%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Algebra.Module.FinitePresentation Mathlib.Algebra.Module.Presentation.Finite |
1 |
Mathlib.RingTheory.Localization.BaseChange |
2 |
Declarations diff
+ AddEquiv.module
+ IsBaseChange.of_equiv
+ IsLocalizedModule.map_lTensor
+ IsLocalizedModule.rTensor
+ IsTensorProduct.of_equiv
+ LinearEquiv.isScalarTower
+ LocalizedModule.restrictScalars_map_eq
+ coe_rTensor
+ flat_of_isLocalized_maximal
+ isBaseChange_tensorProduct_map
+ rTensor
+ rTensor_comp
+ rTensor_id
+ rTensor_mul
+ rTensor_one
+ rTensor_tmul
+ restrictScalars_rTensor
- flat_of_isLocalized_maixmal
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
alreadydone
left a comment
There was a problem hiding this comment.
I've rewritten my aux lemma using your IsLocalizedModule_tensorProduct_map; it's now shorter than before and allows me to golf your span proof and also prove a maximal version: fc2c9d3
|
Nice, feel free to push your commit directly to the branch. |
|
maintainer delegate |
|
🚀 Pull request has been placed on the maintainer queue by alreadydone. |
alreadydone
left a comment
There was a problem hiding this comment.
Thanks! Pushed a bit of golfs.
…athlib4 into chrisflav-flat-meta.2
|
@alreadydone Could you please give this another |
Sorry, missed the message. Pinged in |
|
Thanks a lot! bors merge |
Generalize `Module.Flat.flat_of_isLocalized_span` to take `s : Set S` for any `R`-algebra `S`. Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
flat_of_isLocalized_spanflat_of_isLocalized_span
Generalize
Module.Flat.flat_of_isLocalized_spanto takes : Set Sfor anyR-algebraS.