Skip to content

[Merged by Bors] - feat: port Topology.Bases#1910

Closed
urkud wants to merge 6 commits intomasterfrom
port/Topology.Bases
Closed

[Merged by Bors] - feat: port Topology.Bases#1910
urkud wants to merge 6 commits intomasterfrom
port/Topology.Bases

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Jan 28, 2023


Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) mathlib-port This is a port of a theory file from mathlib. labels Jan 28, 2023
@kim-em kim-em added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Jan 28, 2023
@urkud urkud force-pushed the port/Topology.Bases branch from bcbcbf0 to 7935e8b Compare January 31, 2023 22:35
urkud added 4 commits January 31, 2023 16:36
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@urkud urkud force-pushed the port/Topology.Bases branch from 7935e8b to 533af06 Compare January 31, 2023 22:36
@urkud urkud added awaiting-review and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Jan 31, 2023
Copy link
Copy Markdown
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@kim-em kim-em added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Feb 1, 2023
bors bot pushed a commit that referenced this pull request Feb 1, 2023
@bors
Copy link
Copy Markdown

bors bot commented Feb 1, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Topology.Bases [Merged by Bors] - feat: port Topology.Bases Feb 1, 2023
@bors bors bot closed this Feb 1, 2023
@bors bors bot deleted the port/Topology.Bases branch February 1, 2023 00:49
edegeltje added a commit that referenced this pull request Nov 22, 2024
also make use of the newly available notation for the relevant function, where grep can find it
mathlib-bors bot pushed a commit that referenced this pull request Nov 23, 2024
…ing lean4 issue #1910 (#19380)

this PR removes 3 porting notes regarding lean4 issue leanprover/lean4#1910, and makes adaptations to mathlib to make use of the newly working notation. Concretely, that means that `OrderHom.lfp f` now is written `f.lfp`, and similar for `OrderHom.dual` and `OrderHom.gfp`.

there might still be some `dual x` application left inside code with `open OrderHom`, but those are hard to filter for with grep, as there are many declarations named `dual` in different namespaces.
mathlib-bors bot pushed a commit that referenced this pull request Nov 23, 2024
…issue #1910 to refer to lean4 issue #1629 instead (#19381)

These notes refer to the fact that `LinearMap.ker` and friends cannot be used as `f.ker`. However, this fails not because
the function `LinearMap.ker` needs to be coerced to a proper function (which the issue leanprover/lean4#1910 is about), but because the argument `f` has a type (`LinearMap`) that doesn't occur directly as type of an argument to `LinearMap.ker`. The issue leanprover/lean4#1629 *does* suggest a fix for this.
mathlib-bors bot pushed a commit that referenced this pull request Nov 23, 2024
…o refer to lean4 issue #6178 instead  (#19385)

These adaptation notes refer to the `pp_nodot` attribute not doing anything on certain declarations, due to their inability to be used with dot notation. However, now that leanprover/lean4#1910 has been fixed, the limiting factor has become the fact that the pretty printer doesn't work for these kinds of dot notation, which leanprover/lean4#6178 is an issue for.

As such, the links to the blocking lean issue have been changed in this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants