Skip to content

[Merged by Bors] - feat: port RingTheory.Congruence#1629

Closed
ChrisHughes24 wants to merge 6 commits intomasterfrom
port/RingTheory.Congruence
Closed

[Merged by Bors] - feat: port RingTheory.Congruence#1629
ChrisHughes24 wants to merge 6 commits intomasterfrom
port/RingTheory.Congruence

Conversation

@ChrisHughes24
Copy link
Copy Markdown
Member


Open in Gitpod

@ChrisHughes24 ChrisHughes24 added awaiting-review mathlib-port This is a port of a theory file from mathlib. labels Jan 17, 2023
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@kim-em kim-em added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jan 17, 2023
bors bot pushed a commit that referenced this pull request Jan 17, 2023
@bors
Copy link
Copy Markdown

bors bot commented Jan 17, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port RingTheory.Congruence [Merged by Bors] - feat: port RingTheory.Congruence Jan 17, 2023
@bors bors bot closed this Jan 17, 2023
@bors bors bot deleted the port/RingTheory.Congruence branch January 17, 2023 15:39
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 23, 2024
…issue #1910 to refer to lean4 issue #1629 instead (#19381)

These notes refer to the fact that `LinearMap.ker` and friends cannot be used as `f.ker`. However, this fails not because
the function `LinearMap.ker` needs to be coerced to a proper function (which the issue leanprover/lean4#1910 is about), but because the argument `f` has a type (`LinearMap`) that doesn't occur directly as type of an argument to `LinearMap.ker`. The issue leanprover/lean4#1629 *does* suggest a fix for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants