[Merged by Bors] - chore (RingTheory.Kaehler): reasonable heartbeat limits#6178
Closed
mattrobball wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - chore (RingTheory.Kaehler): reasonable heartbeat limits#6178mattrobball wants to merge 3 commits intomasterfrom
mattrobball wants to merge 3 commits intomasterfrom
Conversation
|
✌️ mattrobball can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors merge |
|
👎 Rejected by label |
Something recent in master made things worse...
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
In light of #6141, we can change the heart beats to more representantive numbers. Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
adomani
pushed a commit
that referenced
this pull request
Jul 28, 2023
In light of #6141, we can change the heart beats to more representantive numbers. Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
kim-em
pushed a commit
that referenced
this pull request
Aug 14, 2023
In light of #6141, we can change the heart beats to more representantive numbers. Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 23, 2024
…o refer to lean4 issue #6178 instead (#19385) These adaptation notes refer to the `pp_nodot` attribute not doing anything on certain declarations, due to their inability to be used with dot notation. However, now that leanprover/lean4#1910 has been fixed, the limiting factor has become the fact that the pretty printer doesn't work for these kinds of dot notation, which leanprover/lean4#6178 is an issue for. As such, the links to the blocking lean issue have been changed in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In light of #6141, we can change the heart beats to more representantive numbers.
I understand the argument about low margin heartbeats being brittle but #6149 will eliminate these one way or another shortly. In the meantime, it is useful to have reasonable baselines for testing performance.
