Skip to content

[Merged by Bors] - refactor(Topology/Category): refactor Profinite.Basic#13909

Closed
dagurtomas wants to merge 20 commits intomasterfrom
dagur/RefactorProfiniteBasic
Closed

[Merged by Bors] - refactor(Topology/Category): refactor Profinite.Basic#13909
dagurtomas wants to merge 20 commits intomasterfrom
dagur/RefactorProfiniteBasic

Conversation

@dagurtomas
Copy link
Copy Markdown
Contributor

@dagurtomas dagurtomas commented Jun 17, 2024

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 17, 2024

PR summary 9308991747

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Topology.Category.Profinite.Basic 1295 1293 -2 (-0.15%)
Mathlib.Topology.Category.Profinite.Product 1296 1294 -2 (-0.15%)
Mathlib.Topology.Category.Profinite.AsLimit 1299 1297 -2 (-0.15%)
Mathlib.Topology.Category.Profinite.CofilteredLimit 1305 1303 -2 (-0.15%)
Mathlib.Topology.Category.LightProfinite.Basic 1326 1324 -2 (-0.15%)
Mathlib.Topology.Category.Profinite.Limits 1338 1337 -1 (-0.07%)
Import changes for all files
Files Import difference
7 files Mathlib.Topology.Category.Profinite.CofilteredLimit Mathlib.Topology.Category.Profinite.AsLimit Mathlib.Topology.Category.Profinite.Basic Mathlib.Topology.Category.Compactum Mathlib.Topology.Category.LightProfinite.Basic Mathlib.Topology.Category.LightProfinite.Sequence Mathlib.Topology.Category.Profinite.Product
-2
Mathlib.Topology.Category.LightProfinite.Limits Mathlib.Topology.Category.Profinite.Limits -1

Declarations diff

+ FintypeCat.toProfiniteFullyFaithful
+ instance (X : Type*) [TopologicalSpace X]
+ instance : FintypeCat.toProfinite.Faithful := FintypeCat.toProfiniteFullyFaithful.faithful
+ instance : FintypeCat.toProfinite.Full := FintypeCat.toProfiniteFullyFaithful.full
- Profinite
- Profinite.toTopCat
- Profinite.to_compHausToTopCat
- category
- coe_comp
- coe_id
- concreteCategory
- forget_ContinuousMap_mk
- forget_reflectsIsomorphisms
- hasForget₂
- homeoOfIso
- instance : CoeSort Profinite Type*
- instance : FintypeCat.toProfinite.Faithful
- instance : FintypeCat.toProfinite.Full
- instance : Profinite.toTopCat.Faithful
- instance : Profinite.toTopCat.Full
- instance : profiniteToCompHaus.Faithful
- instance : profiniteToCompHaus.Full
- instance {X : Profinite} : CompactSpace ((forget Profinite).obj X) := by
- instance {X : Profinite} : T2Space ((forget Profinite).obj X) := by
- instance {X : Profinite} : TopologicalSpace ((forget Profinite).obj X) := by
- instance {X Y : Profinite} (f : X ⟶ Y) [@Epi CompHaus _ _ _ f] : Epi f := by
- instance {X Y : Profinite} (f : X ⟶ Y) [Epi f] : @Epi CompHaus _ _ _ f := by
- isClosedMap
- isIso_of_bijective
- isoEquivHomeo
- isoOfBijective
- isoOfHomeo
- mono_iff_injective
- of
- profiniteToCompHaus

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@ghost ghost added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jun 17, 2024
@dagurtomas dagurtomas added awaiting-review t-category-theory Category theory t-topology Topological spaces, uniform spaces, metric spaces, filters labels Jun 17, 2024
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 19, 2024
@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 2, 2024
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 5, 2024
@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 10, 2024
@ghost ghost removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jul 16, 2024
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Jul 17, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 17, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 17, 2024
This is the second part of the refactor of CompHaus and friends (refactoring the definition of `Profinite` in terms of `CompHausLike`, see #12930 for the end result)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 17, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(Topology/Category): refactor Profinite.Basic [Merged by Bors] - refactor(Topology/Category): refactor Profinite.Basic Jul 17, 2024
@mathlib-bors mathlib-bors bot closed this Jul 17, 2024
@mathlib-bors mathlib-bors bot deleted the dagur/RefactorProfiniteBasic branch July 17, 2024 18:38
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants