Skip to content

[Merged by Bors] - refactor(Topology/Category): add CompHausLike.Basic#13904

Closed
dagurtomas wants to merge 6 commits intomasterfrom
dagur/AddCompHausLike
Closed

[Merged by Bors] - refactor(Topology/Category): add CompHausLike.Basic#13904
dagurtomas wants to merge 6 commits intomasterfrom
dagur/AddCompHausLike

Conversation

@dagurtomas
Copy link
Copy Markdown
Contributor

This is the first part of the refactor of CompHaus and friends (adding the new API which will eventually be used to redefine the categories of compact Hausdorff spaces, see #12930)


Open in Gitpod

@dagurtomas dagurtomas added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-category-theory Category theory t-topology Topological spaces, uniform spaces, metric spaces, filters labels Jun 17, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 17, 2024

PR summary 676af2a8a2

Import changes

No significant changes to the import graph


Declarations diff

+ CompHausLike
+ HasProp
+ category
+ coe_comp
+ coe_id
+ coe_of
+ compHausLikeToTop
+ concreteCategory
+ epi_of_surjective
+ forget_reflectsIsomorphisms
+ fullyFaithfulCompHausLikeToTop
+ fullyFaithfulToCompHausLike
+ hasForget₂
+ homeoOfIso
+ instance (X : CompHausLike P) : CompactSpace ((compHausLikeToTop P).obj X)
+ instance (X : CompHausLike P) : T2Space ((compHausLikeToTop P).obj X)
+ instance (X : CompHausLike.{u} P) : CompactSpace ((forget (CompHausLike P)).obj X)
+ instance (X : CompHausLike.{u} P) : T2Space ((forget (CompHausLike P)).obj X)
+ instance (X : CompHausLike.{u} P) : TopologicalSpace ((forget (CompHausLike P)).obj X)
+ instance : (compHausLikeToTop P).Faithful
+ instance : (compHausLikeToTop P).Full
+ instance : (toCompHausLike h).Faithful := (fullyFaithfulToCompHausLike h).faithful
+ instance : (toCompHausLike h).Full := (fullyFaithfulToCompHausLike h).full
+ instance : CoeSort (CompHausLike P) (Type u)
+ isClosedMap
+ isIso_of_bijective
+ isoEquivHomeo
+ isoOfBijective
+ isoOfHomeo
+ mono_iff_injective
+ of
+ toCompHausLike

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@joelriou joelriou added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Jun 19, 2024
dagurtomas and others added 2 commits June 19, 2024 13:08
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@dagurtomas dagurtomas added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Jun 19, 2024
@dagurtomas dagurtomas added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 19, 2024
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 19, 2024
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@joelriou
Copy link
Copy Markdown
Contributor

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 19, 2024

✌️ dagurtomas can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Jun 19, 2024
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@dagurtomas
Copy link
Copy Markdown
Contributor Author

Thanks for the reviews!

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jun 19, 2024
This is the first part of the refactor of `CompHaus` and friends (adding the new API which will eventually be used to redefine  the categories of compact Hausdorff spaces, see #12930)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 19, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(Topology/Category): add CompHausLike.Basic [Merged by Bors] - refactor(Topology/Category): add CompHausLike.Basic Jun 19, 2024
@mathlib-bors mathlib-bors bot closed this Jun 19, 2024
@mathlib-bors mathlib-bors bot deleted the dagur/AddCompHausLike branch June 19, 2024 15:52
AntoineChambert-Loir pushed a commit that referenced this pull request Jun 20, 2024
This is the first part of the refactor of `CompHaus` and friends (adding the new API which will eventually be used to redefine  the categories of compact Hausdorff spaces, see #12930)
kbuzzard pushed a commit that referenced this pull request Jun 26, 2024
This is the first part of the refactor of `CompHaus` and friends (adding the new API which will eventually be used to redefine  the categories of compact Hausdorff spaces, see #12930)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-category-theory Category theory t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants