[Merged by Bors] - refactor(Topology/Category): refactor CompHaus.Basic#13908
Closed
dagurtomas wants to merge 12 commits intomasterfrom
Closed
[Merged by Bors] - refactor(Topology/Category): refactor CompHaus.Basic#13908dagurtomas wants to merge 12 commits intomasterfrom
dagurtomas wants to merge 12 commits intomasterfrom
Conversation
PR summary 77b5a55be6
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Topology.Category.CompHaus.Basic | 1288 | 1287 | -1 (-0.08%) |
| Mathlib.Topology.Category.Profinite.Basic | 1296 | 1295 | -1 (-0.08%) |
| Mathlib.Topology.Category.Compactum | 1301 | 1300 | -1 (-0.08%) |
| Mathlib.Topology.Category.Stonean.Basic | 1315 | 1314 | -1 (-0.08%) |
Import changes for all files
| Files | Import difference |
|---|---|
13 filesMathlib.Topology.Category.Stonean.Adjunctions Mathlib.Topology.Category.Profinite.CofilteredLimit Mathlib.Topology.Category.Profinite.AsLimit Mathlib.Topology.Category.CompHaus.Basic Mathlib.Topology.Category.CompHaus.Projective Mathlib.Topology.Category.Profinite.Projective Mathlib.Topology.Category.Profinite.Basic Mathlib.Topology.Category.Compactum Mathlib.Topology.Category.Stonean.Basic Mathlib.Topology.Category.Locale Mathlib.Order.Category.Frm Mathlib.Topology.Category.Profinite.Product Mathlib.Topology.Order.Category.FrameAdjunction |
-1 |
5 filesMathlib.Condensed.Light.Explicit Mathlib.Condensed.Light.TopComparison Mathlib.Condensed.Light.Module Mathlib.Condensed.Light.Discrete Mathlib.Condensed.Epi |
1 |
Declarations diff
+ instance : HasProp (fun _ ↦ True) X := ⟨trivial⟩
- CompHaus
- CompHaus.forget_reflectsIsomorphisms
- category
- coe_of
- coe_toTop
- compHausToTop
- concreteCategory
- instance (X : CompHaus) : CompactSpace (compHausToTop.obj X)
- instance (X : CompHaus) : T2Space (compHausToTop.obj X)
- instance (X : CompHaus.{u}) : CompactSpace ((forget CompHaus).obj X)
- instance (X : CompHaus.{u}) : T2Space ((forget CompHaus).obj X)
- instance (X : CompHaus.{u}) : TopologicalSpace ((forget CompHaus).obj X)
- instance : compHausToTop.Faithful
- instance : compHausToTop.Full
- isClosedMap
- isIso_of_bijective
- isoEquivHomeo
- isoOfBijective
- isoOfHomeo
- mono_iff_injective
- of
--++--+ homeoOfIso
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
This was referenced Jun 17, 2024
|
This PR/issue depends on: |
Member
|
Thanks! bors d+ |
Contributor
|
✌️ dagurtomas can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
This PR refactors the file `CompHaus.Basic` in terms of the new `CompHausLike` API. Other files are touched only to fix errors created by this refactor, they will be refactored later (in particular, the API for explicit limits will be mostly removed in favour of the general API for explicit limits in `CompHausLike`, see #12930).
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
This PR refactors the file `CompHaus.Basic` in terms of the new `CompHausLike` API. Other files are touched only to fix errors created by this refactor, they will be refactored later (in particular, the API for explicit limits will be mostly removed in favour of the general API for explicit limits in `CompHausLike`, see #12930).
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
This PR refactors the file `CompHaus.Basic` in terms of the new `CompHausLike` API. Other files are touched only to fix errors created by this refactor, they will be refactored later (in particular, the API for explicit limits will be mostly removed in favour of the general API for explicit limits in `CompHausLike`, see #12930).
Contributor
|
Build failed: |
Contributor
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
This PR refactors the file `CompHaus.Basic` in terms of the new `CompHausLike` API. Other files are touched only to fix errors created by this refactor, they will be refactored later (in particular, the API for explicit limits will be mostly removed in favour of the general API for explicit limits in `CompHausLike`, see #12930).
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the file
CompHaus.Basicin terms of the newCompHausLikeAPI. Other files are touched only to fix errors created by this refactor, they will be refactored later (in particular, the API for explicit limits will be mostly removed in favour of the general API for explicit limits inCompHausLike, see #12930).