[Merged by Bors] - chore: adding missing copyright years#13247
Closed
[Merged by Bors] - chore: adding missing copyright years#13247
Conversation
…st year; I presume the real code goes back to leanprover-community/mathlib3#1716 in 2019.
…diff-a959c7a7d6b5f608638e708fc07590f8a8e1f7b86f05cd9296b0bf3574f86760; which moved content from analysis/complex/basic... which also goes back to 2019 (e.g. the lemma has_deriv_at.real_of_complex was added in leanprover-community/mathlib3#1716.
This was referenced May 26, 2024
TwoFX
approved these changes
May 26, 2024
Member
TwoFX
left a comment
There was a problem hiding this comment.
Thanks! I feel ashamed to appear in this PR ;)
bors r+
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 26, 2024
Five copyright headers were missing a year: add this - so the new style linter can enforce this rule.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Contributor
Author
|
Thanks for the fast review! And no reason to be ashamed - certainly, I would rather celebrate finding mistakes (because then we can learn) than shaming people for them. More seriously: everybody makes mistakes; there was no linter for this back then, so I'm glad my rewrite found something. |
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
Five copyright headers were missing a year: add this - so the new style linter can enforce this rule.
js2357
pushed a commit
that referenced
this pull request
Jun 18, 2024
Five copyright headers were missing a year: add this - so the new style linter can enforce this rule.
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 23, 2024
This is one in a series of PRs rewriting most checks from `lint-style.py` in Lean. This PR moves the check for copyright headers and authors: the check has been rewritten anew (and is hopefully simpler to understand now); this has made it stricter in various places. The necessary adjustments have been made in #13212 and #13247. This PR also adds a `nolints` file for text-based linters.
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
This is one in a series of PRs rewriting most checks from `lint-style.py` in Lean. This PR moves the check for copyright headers and authors: the check has been rewritten anew (and is hopefully simpler to understand now); this has made it stricter in various places. The necessary adjustments have been made in #13212 and #13247. This PR also adds a `nolints` file for text-based linters.
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
This is one in a series of PRs rewriting most checks from `lint-style.py` in Lean. This PR moves the check for copyright headers and authors: the check has been rewritten anew (and is hopefully simpler to understand now); this has made it stricter in various places. The necessary adjustments have been made in #13212 and #13247. This PR also adds a `nolints` file for text-based linters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five copyright headers were missing a year: add this - so the new style linter can enforce this rule.
Each file is in its own commit; the commit messages describes the key reasons why I chose that specific year.