[Merged by Bors] - chore: normalise copyright headers#13212
Closed
[Merged by Bors] - chore: normalise copyright headers#13212
Conversation
… we want Implementing a stricter linter exposed these, so why not just fix them?
I don't care which one is used; make them all equal makes linting easier
15 tasks
Member
|
Thanks 🎉 bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 25, 2024
Re-implementing the copyright header linter in #13199, I made the checker stricter in a few places. This was not intentional, but happened since I wasn't aiming at bug-for-bug compatibility: the old algorithm feels somewhat complicated for me. This led me to perform a few normalisations on the existing copyright headers: let me know if these are desired or not - normalise the copyright symbol in the first line (a few files had a different one) - add a dot in before the "All rights reserved" (again, only a few different ones) - three manual tweaks
Contributor
Author
|
Thank you for the fast review! |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
Re-implementing the copyright header linter in #13199, I made the checker stricter in a few places. This was not intentional, but happened since I wasn't aiming at bug-for-bug compatibility: the old algorithm feels somewhat complicated for me. This led me to perform a few normalisations on the existing copyright headers: let me know if these are desired or not - normalise the copyright symbol in the first line (a few files had a different one) - add a dot in before the "All rights reserved" (again, only a few different ones) - three manual tweaks
js2357
pushed a commit
that referenced
this pull request
Jun 18, 2024
Re-implementing the copyright header linter in #13199, I made the checker stricter in a few places. This was not intentional, but happened since I wasn't aiming at bug-for-bug compatibility: the old algorithm feels somewhat complicated for me. This led me to perform a few normalisations on the existing copyright headers: let me know if these are desired or not - normalise the copyright symbol in the first line (a few files had a different one) - add a dot in before the "All rights reserved" (again, only a few different ones) - three manual tweaks
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 23, 2024
This is one in a series of PRs rewriting most checks from `lint-style.py` in Lean. This PR moves the check for copyright headers and authors: the check has been rewritten anew (and is hopefully simpler to understand now); this has made it stricter in various places. The necessary adjustments have been made in #13212 and #13247. This PR also adds a `nolints` file for text-based linters.
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
This is one in a series of PRs rewriting most checks from `lint-style.py` in Lean. This PR moves the check for copyright headers and authors: the check has been rewritten anew (and is hopefully simpler to understand now); this has made it stricter in various places. The necessary adjustments have been made in #13212 and #13247. This PR also adds a `nolints` file for text-based linters.
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
This is one in a series of PRs rewriting most checks from `lint-style.py` in Lean. This PR moves the check for copyright headers and authors: the check has been rewritten anew (and is hopefully simpler to understand now); this has made it stricter in various places. The necessary adjustments have been made in #13212 and #13247. This PR also adds a `nolints` file for text-based linters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implementing the copyright header linter in #13199, I made the checker stricter in a few places. This was not intentional, but happened since I wasn't aiming at bug-for-bug compatibility: the old algorithm feels somewhat complicated for me.
This led me to perform a few normalisations on the existing copyright headers: let me know if these are desired or not