[Merged by Bors] - feat: rewrite the copyright header check in Lean#13240
Closed
[Merged by Bors] - feat: rewrite the copyright header check in Lean#13240
Conversation
15 tasks
for Lean.Elab since this is transitively imported otherwise.
b32817e to
bb0d550
Compare
…the build! This does not work reliably in CI...
e09bf3b to
570fb91
Compare
eric-wieser
reviewed
May 28, 2024
eric-wieser
reviewed
May 28, 2024
eric-wieser
reviewed
May 28, 2024
exceptions to this form.
PR summary 18dae01c0bImport changesNo significant changes to the import graph Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
deb385c to
4aab587
Compare
4aab587 to
9b16f4e
Compare
Contributor
|
bors merge |
Contributor
|
Merge conflict. |
Contributor
|
bors d+ |
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
9d5bfa2 to
18dae01
Compare
Contributor
Author
|
Thanks for the review! Since CI passes now, let me bors it already: |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 23, 2024
This is one in a series of PRs rewriting most checks from `lint-style.py` in Lean. This PR moves the check for copyright headers and authors: the check has been rewritten anew (and is hopefully simpler to understand now); this has made it stricter in various places. The necessary adjustments have been made in #13212 and #13247. This PR also adds a `nolints` file for text-based linters.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
This is one in a series of PRs rewriting most checks from `lint-style.py` in Lean. This PR moves the check for copyright headers and authors: the check has been rewritten anew (and is hopefully simpler to understand now); this has made it stricter in various places. The necessary adjustments have been made in #13212 and #13247. This PR also adds a `nolints` file for text-based linters.
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
This is one in a series of PRs rewriting most checks from `lint-style.py` in Lean. This PR moves the check for copyright headers and authors: the check has been rewritten anew (and is hopefully simpler to understand now); this has made it stricter in various places. The necessary adjustments have been made in #13212 and #13247. This PR also adds a `nolints` file for text-based linters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one in a series of PRs rewriting most checks from
lint-style.pyin Lean.This PR moves the check for copyright headers and authors: the check has been rewritten anew (and is hopefully simpler to understand now); this has made it stricter in various places. The necessary adjustments have been made in #13212 and #13247.
This PR also adds a
nolintsfile for text-based linters.This linter is slightly slower than the Python linter: in local testing,
lake exe lint_stylewith a no-op linter (incrementing a counter on each file) takes 0.4s(
time lake exe lint_stylereportsreal 0m0,404s; user 0m0,254s; sys 0m0,070s; this is the second time when no re-compilation is needed)Any insight into minimising the no-op overhead is welcome (but almost surely out of scope for this PR).