Skip to content

[Merged by Bors] - chore: adapt to multiple goal linter 7#12908

Closed
adomani wants to merge 1 commit intomasterfrom
adomani/use_cdot_7
Closed

[Merged by Bors] - chore: adapt to multiple goal linter 7#12908
adomani wants to merge 1 commit intomasterfrom
adomani/use_cdot_7

Conversation

@adomani
Copy link
Copy Markdown
Contributor

@adomani adomani commented May 14, 2024

Missing cdots, un unused congr and a stray goal that was solved en-passant since the start of the linter at #12339.


Open in Gitpod

Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented May 16, 2024

Let me use my new super-power: I still think this is a good idea.
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 16, 2024
@fpvandoorn
Copy link
Copy Markdown
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels May 16, 2024
mathlib-bors bot pushed a commit that referenced this pull request May 16, 2024
Missing cdots, un unused `congr` and a stray goal that was solved en-passant since the start of the linter at #12339.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: adapt to multiple goal linter 7 [Merged by Bors] - chore: adapt to multiple goal linter 7 May 16, 2024
@mathlib-bors mathlib-bors bot closed this May 16, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/use_cdot_7 branch May 16, 2024 11:37
callesonne pushed a commit that referenced this pull request May 16, 2024
Missing cdots, un unused `congr` and a stray goal that was solved en-passant since the start of the linter at #12339.
grunweg pushed a commit that referenced this pull request May 17, 2024
Missing cdots, un unused `congr` and a stray goal that was solved en-passant since the start of the linter at #12339.
mathlib-bors bot pushed a commit that referenced this pull request Oct 21, 2024
A linter that makes sure that, when multiple goals are present, they are enclosed in `·`s.

Adaptations (the order is chronological, there should be no dependency among them):
* #12338,
* #12361,
* #12372,
* #12560,
* #12834,
* #12381,
* #12908,
* #14939,

plus many many more that this comment is too small to contain.



Co-authored-by: Michael Rothgang <rothgami@math.hu-berlin.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants