[Merged by Bors] - chore: adapt to multiple goal linter 2#12361
Closed
[Merged by Bors] - chore: adapt to multiple goal linter 2#12361
Conversation
This was referenced Apr 23, 2024
Vierkantor
reviewed
Apr 25, 2024
Vierkantor
reviewed
Apr 25, 2024
| cyclotomic_mul_prime_pow_eq _ _ a.succ_pos, ← pow_mul] | ||
| congr 1 | ||
| simp only [tsub_zero, Nat.succ_sub_succ_eq_sub] | ||
| rwa [Nat.mul_sub_right_distrib, mul_comm, pow_succ] |
Contributor
There was a problem hiding this comment.
Does this mean that rwa used assumption on a different goal than the one it rewrote? :O
Vierkantor
reviewed
Apr 25, 2024
Comment on lines
176
to
+179
| refine' (le_of_eq _).trans (ContinuousMap.norm_coe_le_norm _ ⟨-x, _⟩) | ||
| rw [ContinuousMap.restrict_apply_mk, ContinuousMap.comp_apply, ContinuousMap.coe_mk, | ||
| ContinuousMap.coe_mk, neg_neg] | ||
| exact ⟨by linarith [hx.2], by linarith [hx.1]⟩ | ||
| · rw [ContinuousMap.restrict_apply_mk, ContinuousMap.comp_apply, ContinuousMap.coe_mk, | ||
| ContinuousMap.coe_mk, neg_neg] | ||
| exact ⟨by linarith [hx.2], by linarith [hx.1]⟩ |
Contributor
There was a problem hiding this comment.
Does this really deserve to be indented?
Contributor
Author
There was a problem hiding this comment.
At that point, there are two goals, the second being
-x ∈ Icc (-x✝ + -S) (-x✝ + -R)I do not understand though how Lean solves this one.
Contributor
Author
There was a problem hiding this comment.
Oh, I think that I see now.
The "first goal" becomes identical to the second one after the rw. So, I guess that the final exact solves the current goal and then Lean realizes that it already knows how to solve that goal and closes the second one as well.
Vierkantor
reviewed
Apr 25, 2024
Mathlib/RingTheory/Norm.lean
Outdated
Comment on lines
+277
to
+278
| letI : ∀ f : L →ₐ[K] E, Fintype (@AlgHom L F E _ _ _ _ f.toRingHom.toAlgebra) := ?_ | ||
| rw [Fintype.prod_equiv algHomEquivSigma (fun σ : F →ₐ[K] E => _) fun σ => σ.1 pb.gen, | ||
| ← Finset.univ_sigma_univ, Finset.prod_sigma, ← Finset.prod_pow] | ||
| refine Finset.prod_congr rfl fun σ _ => ?_ | ||
| · letI : Algebra L E := σ.toRingHom.toAlgebra | ||
| simp_rw [Finset.prod_const] | ||
| congr | ||
| exact AlgHom.card L F E | ||
| · intro σ | ||
| simp only [algHomEquivSigma, Equiv.coe_fn_mk, AlgHom.restrictDomain, AlgHom.comp_apply, | ||
| IsScalarTower.coe_toAlgHom'] | ||
| · rw [Fintype.prod_equiv algHomEquivSigma (fun σ : F →ₐ[K] E => _) fun σ => σ.1 pb.gen, |
Contributor
There was a problem hiding this comment.
(Can't add a suggestion here.) Should this be instead something like:
letI : ∀ f : L →ₐ[K] E, Fintype (@AlgHom L F E _ _ _ _ f.toRingHom.toAlgebra) := by
...?
Contributor
Author
There was a problem hiding this comment.
This was puzzling: the letI created an extra goal, wanting to figure out some function. I could not understand where this was used and removing the letI line simply worked!
Maybe this was an instance of an "unused letI"? Is there an "unused have/let" linter? Does it check for letI?
Vierkantor
reviewed
Apr 25, 2024
Contributor
Vierkantor
left a comment
There was a problem hiding this comment.
LGTM otherwise. Thanks for this huge cleanup!
Contributor
Author
|
Anne, thank you very much for your review! |
Member
|
bors d+ |
Contributor
|
✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors r+ |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 13, 2024
This PR was reduced by approximately half of its original size: the other half of this PR is now the content of #12560. This PR was reduced by approximately half of its halved size: the other half of the halved PR is now the content of #12834. A PR analogous to the merged PRs #12338, #12361 and #12372: reformatting proofs following the multiple goals linter of #12339. This should be the last of the adaptations.
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
This PR was reduced by approximately half of its original size: the other half of this PR is now the content of #12560. This PR was reduced by approximately half of its halved size: the other half of the halved PR is now the content of #12834. A PR analogous to the merged PRs #12338, #12361 and #12372: reformatting proofs following the multiple goals linter of #12339. This should be the last of the adaptations.
grunweg
pushed a commit
that referenced
this pull request
May 17, 2024
This PR was reduced by approximately half of its original size: the other half of this PR is now the content of #12560. This PR was reduced by approximately half of its halved size: the other half of the halved PR is now the content of #12834. A PR analogous to the merged PRs #12338, #12361 and #12372: reformatting proofs following the multiple goals linter of #12339. This should be the last of the adaptations.
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
A linter that makes sure that, when multiple goals are present, they are enclosed in `·`s. Adaptations (the order is chronological, there should be no dependency among them): * #12338, * #12361, * #12372, * #12560, * #12834, * #12381, * #12908, * #14939, plus many many more that this comment is too small to contain. Co-authored-by: Michael Rothgang <rothgami@math.hu-berlin.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR analogous to #12338: reformatting proofs following the multiple goals linter of #12339.