[Merged by Bors] - chore: adapt to multiple goal linter 3#12372
Closed
[Merged by Bors] - chore: adapt to multiple goal linter 3#12372
Conversation
This was referenced Apr 23, 2024
Vierkantor
approved these changes
Apr 30, 2024
Contributor
Vierkantor
left a comment
There was a problem hiding this comment.
Everything here looks like a clear improvement to me. Thanks for all the work!
bors r+
Comment on lines
+155
to
+156
| tfae_have 1 ↔ 2 | ||
| · exact Iff.rfl |
Contributor
There was a problem hiding this comment.
Not for this PR but: what do you think about making this a focusing tactic like case? So it would look like:
tfae_have 1 ↔ 2 =>
exact Iff.rfl
Contributor
Author
There was a problem hiding this comment.
This is a good idea! I can see that there will be some discussion about which tactics should be considered scoping and which ones should not. It might even be a good design decision to make it into a (local) flag.
Contributor
|
Build failed (retrying...): |
Contributor
|
bors r- |
Contributor
|
Canceled. |
Contributor
|
bors r+ |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 13, 2024
This PR was reduced by approximately half of its original size: the other half of this PR is now the content of #12560. This PR was reduced by approximately half of its halved size: the other half of the halved PR is now the content of #12834. A PR analogous to the merged PRs #12338, #12361 and #12372: reformatting proofs following the multiple goals linter of #12339. This should be the last of the adaptations.
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
This PR was reduced by approximately half of its original size: the other half of this PR is now the content of #12560. This PR was reduced by approximately half of its halved size: the other half of the halved PR is now the content of #12834. A PR analogous to the merged PRs #12338, #12361 and #12372: reformatting proofs following the multiple goals linter of #12339. This should be the last of the adaptations.
grunweg
pushed a commit
that referenced
this pull request
May 17, 2024
This PR was reduced by approximately half of its original size: the other half of this PR is now the content of #12560. This PR was reduced by approximately half of its halved size: the other half of the halved PR is now the content of #12834. A PR analogous to the merged PRs #12338, #12361 and #12372: reformatting proofs following the multiple goals linter of #12339. This should be the last of the adaptations.
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
A linter that makes sure that, when multiple goals are present, they are enclosed in `·`s. Adaptations (the order is chronological, there should be no dependency among them): * #12338, * #12361, * #12372, * #12560, * #12834, * #12381, * #12908, * #14939, plus many many more that this comment is too small to contain. Co-authored-by: Michael Rothgang <rothgami@math.hu-berlin.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR analogous to #12338 and #12361: reformatting proofs following the multiple goals linter of #12339.