[Merged by Bors] - chore(Geometry): remove a few porting notes#12061
Closed
[Merged by Bors] - chore(Geometry): remove a few porting notes#12061
Conversation
Contributor
Author
|
Inspired by #12059. |
Ruben-VandeVelde
approved these changes
Apr 11, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
In all cases, the original proof fixed itself.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
In all cases, the original proof fixed itself.
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
In all cases, the original proof fixed itself.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
In all cases, the original proof fixed itself.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
In all cases, the original proof fixed itself.
grunweg
added a commit
that referenced
this pull request
Jun 2, 2024
#12061 regressed this file pretty badly; try to speed it up again
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
#12061 regressed this file pretty badly; speed it up again by mostly reverting a change from that PR, and pushing it further: instead of applying `mem_iUnion` (which is slow), extract a more specialised statement `mem_aux` and use it. Before these changes, the `profiler` output on `smoothFiberwiseLinear` was ``` simp took 2.01s tactic execution of Lean.Parser.Tactic.rintro took 103ms simp took 905ms simp took 507ms simp took 1.26s simp took 1.14s elaboration took 645ms ``` after these changes, it is ``` simp took 534ms simp took 183ms simp took 127ms simp took 421ms simp took 365ms elaboration took 350ms ``` Still not great at all, but deeper fixes require more time and expertise than I currently have.
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
#12061 regressed this file pretty badly; speed it up again by mostly reverting a change from that PR, and pushing it further: instead of applying `mem_iUnion` (which is slow), extract a more specialised statement `mem_aux` and use it. Before these changes, the `profiler` output on `smoothFiberwiseLinear` was ``` simp took 2.01s tactic execution of Lean.Parser.Tactic.rintro took 103ms simp took 905ms simp took 507ms simp took 1.26s simp took 1.14s elaboration took 645ms ``` after these changes, it is ``` simp took 534ms simp took 183ms simp took 127ms simp took 421ms simp took 365ms elaboration took 350ms ``` Still not great at all, but deeper fixes require more time and expertise than I currently have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In all cases, the original proof fixed itself.
I haven't tried to track down why.
The proof
mem_smoothFiberwiseLinear_iffseemingly still requiresmem_aux; I'm not quite sure why.