[Merged by Bors] - perf(VectorBundle/FiberwiseLinear): speed up#13454
Closed
[Merged by Bors] - perf(VectorBundle/FiberwiseLinear): speed up#13454
Conversation
#12061 regressed this file pretty badly; try to speed it up again
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 99a4f06. Benchmark Metric Change
===============================================================================
+ ~Mathlib.Geometry.Manifold.VectorBundle.FiberwiseLinear instructions -38.7% |
by adding an x argument
3ec0233 to
a27a9cb
Compare
Member
|
Do you know why |
Contributor
Author
|
I do not. Understanding and fixing this would be nice. Would you like me to add a TODO? |
Member
|
Yes, please. Otherwise LGTM. Thanks! |
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
grunweg
commented
Jun 10, 2024
Contributor
Author
|
Thanks for the review! |
PR summaryImport changesNo significant changes to the import graph Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
#12061 regressed this file pretty badly; speed it up again by mostly reverting a change from that PR, and pushing it further: instead of applying `mem_iUnion` (which is slow), extract a more specialised statement `mem_aux` and use it. Before these changes, the `profiler` output on `smoothFiberwiseLinear` was ``` simp took 2.01s tactic execution of Lean.Parser.Tactic.rintro took 103ms simp took 905ms simp took 507ms simp took 1.26s simp took 1.14s elaboration took 645ms ``` after these changes, it is ``` simp took 534ms simp took 183ms simp took 127ms simp took 421ms simp took 365ms elaboration took 350ms ``` Still not great at all, but deeper fixes require more time and expertise than I currently have.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
#12061 regressed this file pretty badly; speed it up again by mostly reverting a change from that PR, and pushing it further: instead of applying `mem_iUnion` (which is slow), extract a more specialised statement `mem_aux` and use it. Before these changes, the `profiler` output on `smoothFiberwiseLinear` was ``` simp took 2.01s tactic execution of Lean.Parser.Tactic.rintro took 103ms simp took 905ms simp took 507ms simp took 1.26s simp took 1.14s elaboration took 645ms ``` after these changes, it is ``` simp took 534ms simp took 183ms simp took 127ms simp took 421ms simp took 365ms elaboration took 350ms ``` Still not great at all, but deeper fixes require more time and expertise than I currently have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12061 regressed this file pretty badly; speed it up again by mostly reverting a change from that PR, and pushing it further: instead of applying
mem_iUnion(which is slow), extract a more specialised statementmem_auxand use it.Before these changes, the
profileroutput onsmoothFiberwiseLinearwasafter these changes, it is
Still not great at all, but deeper fixes require more time and expertise than I currently have.
I cannot recover the link to the post-merge perf. run from speed.lean-lang.org; help with that welcome.