[Merged by Bors] - chore: remove some porting notes in sphere#12059
Closed
[Merged by Bors] - chore: remove some porting notes in sphere#12059
Conversation
grunweg
approved these changes
Apr 11, 2024
Contributor
grunweg
left a comment
There was a problem hiding this comment.
Looks like an improvement to me. Thanks for doing this!
(I'm low-to-medium confident on this one.)
Ruben-VandeVelde
approved these changes
Apr 11, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
Found after examining the bug fixes in #12054, although these improvements are unrelated to the test PR.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
Found after examining the bug fixes in #12054, although these improvements are unrelated to the test PR.
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
Found after examining the bug fixes in #12054, although these improvements are unrelated to the test PR.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
Found after examining the bug fixes in #12054, although these improvements are unrelated to the test PR.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Found after examining the bug fixes in #12054, although these improvements are unrelated to the test PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found after examining the bug fixes in #12054, although these improvements are unrelated to the test PR.